-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[5.1] IRGen: Map type into context before asking for class layout. #24934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] IRGen: Map type into context before asking for class layout. #24934
Conversation
Asking for the layout of the interface type apparently gives the wrong answer, causing key paths to access stored properties of generic classes using the wrong strategy. Fixes SR-10167 | rdar://problem/49230751.
@swift-ci Please test |
Build failed |
@swift-ci Please clean test Linux |
Build failed |
@swift-ci Please smoke test Linux |
@swift-ci Please test Linux |
Build failed |
@aciidb0mb3r My pr test has failed three times in a row here during swiftpm testing:
Any known issues with swiftpm right now? |
Could be related to swiftlang/swift-package-manager#2129 |
@aciidb0mb3r - that went into master, this is testing 5.1. Does the 5.1 branch use the master branch of swift-package-manager? If so, we need to pull that change into the 5.1 branch. |
Ugh! I see what happened; swift-corelibs-xctest merged from master into swift-5.1-branch but swift-package-manager did not. I will put up the PR for s-p-m in a minute |
Please test with following PRs: @swift-ci please test Linux platform |
Asking for the layout of the interface type apparently gives the wrong answer,
causing key paths to access stored properties of generic classes using the wrong
strategy.
Fixes SR-10167 | rdar://problem/49230751.