Skip to content

[5.1] IRGen: Map type into context before asking for class layout. #24934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jckarter
Copy link
Contributor

Asking for the layout of the interface type apparently gives the wrong answer,
causing key paths to access stored properties of generic classes using the wrong
strategy.

Fixes SR-10167 | rdar://problem/49230751.

Asking for the layout of the interface type apparently gives the wrong answer,
causing key paths to access stored properties of generic classes using the wrong
strategy.

Fixes SR-10167 | rdar://problem/49230751.
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f1a3673

@jckarter
Copy link
Contributor Author

@swift-ci Please clean test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f1a3673

@jckarter
Copy link
Contributor Author

@swift-ci Please smoke test Linux

@jckarter
Copy link
Contributor Author

@swift-ci Please test Linux

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - f1a3673

@jckarter
Copy link
Contributor Author

@aciidb0mb3r My pr test has failed three times in a row here during swiftpm testing:

/home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-swift-5.1-branch/swiftpm/Tests/PackageDescription4Tests/VersionTests.swift:12:8: error: no such module 'XCTest'
import XCTest
       ^
--- bootstrap: erroe

Any known issues with swiftpm right now?

@aciidgh
Copy link
Contributor

aciidgh commented May 21, 2019

Could be related to swiftlang/swift-package-manager#2129
/cc @compnerd

@compnerd
Copy link
Member

@aciidb0mb3r - that went into master, this is testing 5.1. Does the 5.1 branch use the master branch of swift-package-manager? If so, we need to pull that change into the 5.1 branch.

@compnerd
Copy link
Member

Ugh! I see what happened; swift-corelibs-xctest merged from master into swift-5.1-branch but swift-package-manager did not. I will put up the PR for s-p-m in a minute

@compnerd
Copy link
Member

Please test with following PRs:
swiftlang/swift-package-manager#2130

@swift-ci please test Linux platform

@jckarter jckarter merged commit f66d66d into swiftlang:swift-5.1-branch May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants