[WIP] SE-0066: Standardize Function Type Syntax #2433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's see how many tests fail! |
|
@swift-ci Please test |
|
Hi Harlan, I'm sorry I didn't know that you were working on this. I just landed the full test suite adaptation and a patch to implement this... |
|
Haha, no worries! Definitely wanted to get it landed. 👍 |
|
What about XCTest and Foundation? Are those gonna build properly now? |
|
I didn't try them, right now, they will only get a warning about this. I'll upgrade it to an error in a week or two. |
|
XCTest builds fine for now. The new warnings are resolved in swiftlang/swift-corelibs-xctest#104. |
|
@modocache Thanks! 👍 |
|
Here's one cleaning up Foundation as well: swiftlang/swift-corelibs-foundation#351 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Implements SE-0066: Standardize Function Type Syntax
Still needs test and
stdlibmigration.Resolved bug number: (SR-1434)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.