[5.1-04-24-2019] [code-completion] Add type context for single-expression function bodies #24288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the support for single-expression closures to handle
single-expression functions of all kinds. This allows, e.g.
func foo() -> MyEnum { .<here> }
to complete members of `MyEnum`.
This adds an implicit body so that we can dig out the return type context the same way as a normal function. For now, we are also treating the first expression in a multi-statement implicit getter body the same way; we'll need to refactor how we complete in accessors to differentiate those cases.
|
@swift-ci please test |
akyrtzi
approved these changes
Apr 25, 2019
|
Build failed |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #23587 to swift-5.1-branch-04-24-2019
Reviewed by @rintaro
Extend the support for single-expression closures to handle single-expression functions of all kinds. This allows, e.g.
func foo() -> MyEnum { . }
to complete members of MyEnum.
rdar://problem/48938531