Sema: Fix order dependency in @objc inference from witnessed protocol requirement [5.1] #24256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… requirement If we haven't validated the declaration yet, the 'witnesses @objc requirement' check would immediately fail. Move the validateDecl() call to matchWitness() to fix this. Fixes <rdar://problem/49482328>, <https://bugs.swift.org/browse/SR-10257>.
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@shahmishal Looks like there's an issue with update-checkout on the swift-5.1-branch? |
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test macOS |
It should be resolved now. |
DougGregor
approved these changes
Apr 25, 2019
|
When will swift 5.1 been release？It is really a big problem. |
|
I agree, It was breaking my CollectionViews and who knows what else, which I believe is the main problem, it could be breaking anything silently |
This was referenced Apr 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we haven't validated the declaration yet, the 'witnesses @objc
requirement' check would immediately fail. Move the validateDecl()
call to matchWitness() to fix this.
Fixes rdar://problem/49482328, fixes #52657.