fix warnings #24127
Merged
fix warnings #24127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lorentey I wasn't sure which variable should be used in Thank you. |
|
@Gumichocopengin8 Thank you! A fix for the hashing warnings is already under review as #23832; could you please remove those parts from here? The var → let changes look good! |
|
@lorentey |
|
@swift-ci test |
This comment has been minimized.
This comment has been minimized.
|
Build failed |
|
@lorentey @jrose-apple Could you run test please? |
|
@swift-ci test and merge |
|
@palimondo could you please run test? |
|
@swift-ci test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix warnings.
- Hashable warning-warning: 'Hashable.hashValue' is deprecated as a protocol requirement; conform type 'something' to 'Hashable' by implementing 'hash(into:)