[ModuleInterface] Escape Type and Protocol when they're type members
#24111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
It shouldn't hurt to escape them for methods, right? |
|
I don't think it'd hurt, no. Should I just escape functions instead of special-casing them? |
|
I think that's my preference, especially if we decide to start checking functions in the future. |
harlanhaskins
force-pushed
the
my-type-of-patch
branch
2 times, most recently
from
b3d85bc to
a73daa2
Compare
|
@swift-ci please smoke test |
nathawes
approved these changes
Apr 18, 2019
jrose-apple
approved these changes
Apr 18, 2019
harlanhaskins
force-pushed
the
my-type-of-patch
branch
from
a73daa2 to
5b95804
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
harlanhaskins
force-pushed
the
my-type-of-patch
branch
from
5b95804 to
8f9717e
Compare
Previously, we wouldn't escape `Type` and `Protocol` at all in the ASTPrinter, which lead to unfortunate build failures while compiling an interface. Instead, make sure we escape them whenever we print a name that's a type member. Except for methods, which are erroneously allowed to be called `Type` and `Protocol`. rdar://49858651
harlanhaskins
force-pushed
the
my-type-of-patch
branch
from
8f9717e to
9a31dc1
Compare
|
@swift-ci please smoke test |
harlanhaskins
pushed a commit
to harlanhaskins/swift
that referenced
this pull request
Apr 24, 2019
…ers (swiftlang#24111) Previously, we wouldn't escape `Type` and `Protocol` at all in the ASTPrinter, which lead to unfortunate build failures while compiling an interface. Instead, make sure we escape them whenever we print a name that's a type member. Except for methods, which are erroneously allowed to be called `Type` and `Protocol`. rdar://49858651
harlanhaskins
pushed a commit
that referenced
this pull request
Apr 25, 2019
…ers (#24111) (#24241) Previously, we wouldn't escape `Type` and `Protocol` at all in the ASTPrinter, which lead to unfortunate build failures while compiling an interface. Instead, make sure we escape them whenever we print a name that's a type member. Except for methods, which are erroneously allowed to be called `Type` and `Protocol`. rdar://49858651
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we wouldn't escape
TypeandProtocolat all in theASTPrinter, which lead to unfortunate build failures while compiling an
interface.
Instead, make sure we escape them whenever we print a name that's a type
member. Except for methods, which are erroneously allowed to be called
TypeandProtocol.rdar://49858651