[SwiftPM] Build with foundation #2406
Conversation
| if [[ ! "${SKIP_BUILD_FOUNDATION}" ]] ; then | ||
| PRODUCTS=("${PRODUCTS[@]}" foundation) | ||
| fi | ||
| if [[ ! "${SKIP_BUILD_SWIFTPM}" ]] ; then | ||
| PRODUCTS=("${PRODUCTS[@]}" swiftpm) | ||
| fi |
There was a problem hiding this comment.
Let's go ahead and build SwiftPM after XCTest here, since it also uses XCTest even if it doesn't need it for the initial build currently.
|
@swift-ci please test and merge |
| if [[ ! "${SKIP_BUILD_FOUNDATION}" ]] ; then | ||
| PRODUCTS=("${PRODUCTS[@]}" foundation) | ||
| fi | ||
| # SwiftPM is dependent on XCTest, so XCTest must be added to the list of |
There was a problem hiding this comment.
I don't think SwiftPM actually requires XCTest as a build-time dependency. I would actually prefer to see SwiftPM built first to facilitate migrating XCTest to be built by SwiftPM in the future.
There was a problem hiding this comment.
It doesn't currently, but it does actually use XCTest today (whereas the converse is not true), and I can imagine at some point it might be desirable to "just build".
I think we are going to ultimately have to solve the circular build dependency another way, but would rather start with this order since SwiftPM does use XCTest.
|
@swift-ci please test and merge |
Use `pip3` when `pip` is absent in macOS deps script
What's in this pull request?
A change to the build script to always build SwiftPM with foundation. See also swiftlang/swift-package-manager#292 (comment).
Part of bug number: (SR-1005)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.