Skip to content

Remove slide calculation #23875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2019
Merged

Remove slide calculation #23875

merged 3 commits into from
Apr 9, 2019

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Apr 9, 2019

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

compnerd added 3 commits April 8, 2019 18:52
Don't bother passing the slide for the COFF image as it is always 0.
Don't bother passing the slide for the ELF image as it is always 0.
Don't bother passing the slide for the MachO image as it is always 0.
@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2019

CC: @dcci @jckarter @alexshap

@compnerd
Copy link
Member Author

compnerd commented Apr 9, 2019

@swift-ci please test

@jckarter
Copy link
Contributor

jckarter commented Apr 9, 2019

Awesome, it's great we don't need that anymore!

@compnerd compnerd merged commit 1fa7552 into swiftlang:master Apr 9, 2019
@compnerd compnerd deleted the slides-are-fun branch April 9, 2019 17:39
@alexander-shaposhnikov
Copy link

))))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants