Try using a faster class check

[Catfish-Man]

No description provided.

[Catfish-Man]

@swift-ci please smoke benchmark

[swift-ci]

Build failed before running benchmark.

[Catfish-Man]

@swift-ci please smoke benchmark

[swift-ci]

Performance: -O

TEST	OLD	NEW	DELTA	RATIO
Regression
FlattenListLoop	3978	4335	+9.0%	0.92x
RemoveWhereMoveInts	34	37	+8.8%	0.92x (?)
RemoveWhereSwapInts	60	65	+8.3%	0.92x (?)
StringBuilderWithLongSubstring	1340	1450	+8.2%	0.92x (?)
MapReduce	368	397	+7.9%	0.93x (?)
FlattenListFlatMap	6072	6541	+7.7%	0.93x (?)
MapReduceAnyCollection	369	397	+7.6%	0.93x (?)

Performance: -Osize

TEST	OLD	NEW	DELTA	RATIO
Regression
FlattenListLoop	4069	4435	+9.0%	0.92x (?)
Array2D	6912	7520	+8.8%	0.92x
RemoveWhereSwapInts	62	67	+8.1%	0.93x
Improvement
DictionaryBridgeToObjC_Access	987	879	-10.9%	1.12x (?)
ObjectiveCBridgeStubFromNSDateRef	4400	4050	-8.0%	1.09x (?)

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

[Catfish-Man]

Adding a call that's not used outside of String bridging stuff definitely did not regress Array2D

[Catfish-Man]

@swift-ci please smoke benchmark

[Catfish-Man]

@swift-ci please smoke benchmark

[swift-ci]

Performance: -O

TEST	OLD	NEW	DELTA	RATIO
Improvement
EqualStringSubstring	43	38	-11.6%	1.13x (?)
LessSubstringSubstring	44	39	-11.4%	1.13x
EqualSubstringSubstring	42	38	-9.5%	1.11x (?)
EqualSubstringSubstringGenericEquatable	42	38	-9.5%	1.11x (?)
EqualSubstringString	43	39	-9.3%	1.10x
LessSubstringSubstringGenericComparable	43	39	-9.3%	1.10x

Performance: -Osize

TEST	OLD	NEW	DELTA	RATIO
Improvement
LessSubstringSubstring	44	39	-11.4%	1.13x (?)
EqualSubstringSubstringGenericEquatable	44	39	-11.4%	1.13x
LessSubstringSubstringGenericComparable	44	39	-11.4%	1.13x
EqualSubstringSubstring	43	39	-9.3%	1.10x (?)
EqualStringSubstring	43	39	-9.3%	1.10x (?)
EqualSubstringString	44	40	-9.1%	1.10x (?)
ObjectiveCBridgeStubFromNSDateRef	4390	4050	-7.7%	1.08x (?)

Performance: -Onone

TEST	OLD	NEW	DELTA	RATIO
Improvement
ArrayOfPOD	852	779	-8.6%	1.09x (?)
ObjectiveCBridgeStubFromNSString	904	839	-7.2%	1.08x (?)

How to read the data

The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview

  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

[Catfish-Man]

Hah, thought so!

[Catfish-Man]

@swift-ci please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 1bd2d770bc7314dc5dcd40b057e331f920b6ca6f

[milseman]

Neat, any idea how much faster?

[Catfish-Man]

Neat, any idea how much faster?

Only like 3% or so on our string equality benchmark, but I like not leaving minor perf hazards laying around.

What I really want is to be able to inline this within the stdlib, but I don't see a good way to do that currently, since the fast check is in C++ and we can only inline C (and I don't really want to copy-paste the whole thing and maintain a Swift copy).

[Catfish-Man]

@swift-ci please test

[swift-ci]

Build failed
Swift Test Linux Platform
Git Sha - 8744501dbabdf02b0bc78b1178673b31aeea3f19

[swift-ci]

Build failed
Swift Test OS X Platform
Git Sha - 8744501dbabdf02b0bc78b1178673b31aeea3f19

[Catfish-Man]

@swift-ci please test

[Catfish-Man]

@swift-ci please smoke test and merge

[Catfish-Man]

@swift-ci please smoke test and merge