Allow return to be omitted from single expression functions.#23251

Merged

nate-chandler merged 33 commits intoswiftlang:masterfrom

nate-chandler:nate/omit-return

Apr 25, 2019

Commits on Apr 24, 2019

WIP: Allow return to be omitted from single expression functions.
nate-chandler
committed
Used a constraint system, not typeCheckExpression.
nate-chandler
committed
Just revert return insertion if inappropriate.
nate-chandler
committed
Just reuse old body when reverting return insertion.
nate-chandler
committed
Addressed issues from PR review.
nate-chandler
committed
Tested implicit return of most exprs from free functions.
nate-chandler
committed
Don't insert return during code completion.
nate-chandler
committed
Placed prechecked expressions back in body.
nate-chandler
committed
Only remove return for a unique viable solution.
nate-chandler
committed
Expected errors around implicitly returning #line.
nate-chandler
committed
Avoided double typechecking when possible.
nate-chandler
committed
Added comments explaining approach.
nate-chandler
committed
Visited single expression of AbstractFunctionDecl.
nate-chandler
committed
Corrected autoclosure handling.
nate-chandler
committed
Added diagnostic for dangling expression at end.
nate-chandler
committed
Added tests to cover autoclosure discriminators.
nate-chandler
committed
Used expected-error to test fixit.
nate-chandler
committed
Added PlaygroundTransform tests on implicit return.
nate-chandler
committed
Don't attempt to apply solution from salvage.
nate-chandler
committed
Implicitly convert single exprs from uninhabited.
nate-chandler
committed
Tested implicit non/conversion from uninhabited.
nate-chandler
committed
Don't add an implicit () after return for initializers.
nate-chandler
committed
Corrected tests by removing implicit returns.
nate-chandler
committed
Replaced superseded test.
nate-chandler
committed
Tweaked remaining failing tests.
nate-chandler
committed
Fixed up return omission test cases for Linux.
nate-chandler
committed
[ConstraintLocator] Add a special locator element to denote contextual type of single expr function

xedin
authored and
nate-chandler
committed
[ConstraintSystem] Use special locator for expr representing return of single expr function

xedin
authored and
nate-chandler
committed
Eliminated conversion from uninhabited.
nate-chandler
committed
Don't implicitly return assignments.
nate-chandler
committed
Reverted unneeded test change.
nate-chandler
committed
Removed old comment.
nate-chandler
committed
Corrected off-by-one error.
nate-chandler
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow return to be omitted from single expression functions.#23251

Allow return to be omitted from single expression functions.#23251
nate-chandler merged 33 commits intoswiftlang:masterfrom
nate-chandler:nate/omit-return

Commits on Apr 24, 2019

WIP: Allow return to be omitted from single expression functions.

Used a constraint system, not typeCheckExpression.

Just revert return insertion if inappropriate.

Just reuse old body when reverting return insertion.

Addressed issues from PR review.

Tested implicit return of most exprs from free functions.

Don't insert return during code completion.

Placed prechecked expressions back in body.

Only remove return for a unique viable solution.

Expected errors around implicitly returning #line.

Avoided double typechecking when possible.

Added comments explaining approach.

Visited single expression of AbstractFunctionDecl.

Corrected autoclosure handling.

Added diagnostic for dangling expression at end.

Added tests to cover autoclosure discriminators.

Used expected-error to test fixit.

Added PlaygroundTransform tests on implicit return.

Don't attempt to apply solution from salvage.

Implicitly convert single exprs from uninhabited.

Tested implicit non/conversion from uninhabited.

Don't add an implicit () after return for initializers.

Corrected tests by removing implicit returns.

Replaced superseded test.

Tweaked remaining failing tests.

Fixed up return omission test cases for Linux.

[ConstraintLocator] Add a special locator element to denote contextual type of single expr function

[ConstraintSystem] Use special locator for expr representing return of single expr function

Eliminated conversion from uninhabited.

Don't implicitly return assignments.

Reverted unneeded test change.

Removed old comment.

Corrected off-by-one error.

Allow return to be omitted from single expression functions.#23251nate-chandler merged 33 commits intoswiftlang:masterswiftlang/swift:masterfrom nate-chandler:nate/omit-returnnate-chandler/swift:nate/omit-returnCopy head branch name to clipboard

Commits

Commits on Apr 24, 2019

Allow return to be omitted from single expression functions.#23251
nate-chandler merged 33 commits intoswiftlang:masterfrom
nate-chandler:nate/omit-return