[build-script-impl] Call the XCTest build_script.py on all platforms #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bravo! apple/swift CI doesn't actually test this XCTest code path -- this is the very reason @briancroom made the changes in swiftlang/swift-corelibs-xctest#97 -- so asking @swift-ci to test wouldn't provide much benefit here. Still, I guess it couldn't hurt! I'll wait to see a test run before merging. |
briancroom
force-pushed
the
use-xctest-build-script
branch
2 times, most recently
from
85baaa2 to
b538224
Compare
…orms No longer invoke xcodebuild directly on Darwin for building and testing, because XCTest's own build script now contains the platform-specific logic.
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Following up on #2137 and swiftlang/swift-corelibs-xctest#97, XCTest's own build script has gotten the capability of performing build and test actions on Darwin as well, so
build-script-implcan now delegate to it there, reducing the amount of platform-specific logic here.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.