-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[benchmark] Janitor Duty: Sisyphus Legacy #22296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[benchmark] Janitor Duty: Sisyphus Legacy #22296
Conversation
Also inlined runFunctions and setUpFunctions.
@swift-ci Please benchmark |
@swift-ci Please smoke test |
@eeckstein Please review 🙏 |
Build comment file:Performance: -O
Code size: -O
Performance: -Osize
Code size: -Osize
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
@gottesmm Could you review this in Erik's stead, while he's away please? |
Sorry, I am not available for review for this code. |
@atrick Would you be available to review this, please? 🙏 |
@eeckstein Thank you! |
This PR follows-up #20861, #21413, #21516, #21794 and #22026 in clean-up efforts to enable robust performance measurements by adjusting workloads to run in reasonable time (< 1000 μs), minimizing the accumulated error. To maintain long-term performance tracking, it applies legacy factor where necessary.
This one's just the remainder of benchmarks wading through the rest of the alphabet. (There still might be some loose ends to tie later on...)