Skip to content

[benchmark] Janitor Duty: Sisyphus Legacy #22296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 11, 2019

Conversation

palimondo
Copy link
Contributor

This PR follows-up #20861, #21413, #21516, #21794 and #22026 in clean-up efforts to enable robust performance measurements by adjusting workloads to run in reasonable time (< 1000 μs), minimizing the accumulated error. To maintain long-term performance tracking, it applies legacy factor where necessary.

This one's just the remainder of benchmarks wading through the rest of the alphabet. (There still might be some loose ends to tie later on...)

@palimondo palimondo requested a review from eeckstein February 1, 2019 18:06
@palimondo
Copy link
Contributor Author

@swift-ci Please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci Please smoke test

@palimondo
Copy link
Contributor Author

@eeckstein Please review 🙏

@swift-ci
Copy link
Contributor

swift-ci commented Feb 1, 2019

Build comment file:

Performance: -O

TEST OLD NEW DELTA RATIO
Improvement
ObjectiveCBridgeStubToNSDate2 1346 1247 -7.4% 1.08x (?)

Code size: -O

TEST OLD NEW DELTA RATIO
Improvement
StackPromo.o 2327 1895 -18.6% 1.23x
SequenceAlgos.o 20482 19930 -2.7% 1.03x

Performance: -Osize

TEST OLD NEW DELTA RATIO
Regression
NopDeinit 42600 46500 +9.2% 0.92x (?)

Code size: -Osize

TEST OLD NEW DELTA RATIO
Improvement
StackPromo.o 2373 1909 -19.6% 1.24x
SequenceAlgos.o 20970 20386 -2.8% 1.03x
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 8-Core Intel Xeon E5
  Processor Speed: 3 GHz
  Number of Processors: 1
  Total Number of Cores: 8
  L2 Cache (per Core): 256 KB
  L3 Cache: 25 MB
  Memory: 64 GB
--------------

@palimondo palimondo requested a review from gottesmm February 4, 2019 19:09
@palimondo
Copy link
Contributor Author

@gottesmm Could you review this in Erik's stead, while he's away please?

@gottesmm
Copy link
Contributor

gottesmm commented Feb 4, 2019

Sorry, I am not available for review for this code.

@palimondo palimondo requested review from atrick and removed request for gottesmm February 4, 2019 19:15
@palimondo
Copy link
Contributor Author

@atrick Would you be available to review this, please? 🙏

@palimondo palimondo merged commit 80b9517 into swiftlang:master Feb 11, 2019
@palimondo
Copy link
Contributor Author

@eeckstein Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants