[5.0] [String] ASCII fast-path for UTF16View #20900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes a cherry-pick of #20899, otherwise we would conflict upon either of us being merged. |
|
@apple/swift5-branch-managers
This adds important performance improvements to the ASCII strings which are bridged to Cocoa. This is a very frequent use case (identifiers, selectors, key paths, etc).
This has no ABI impact. |
|
@swift-ci please test |
|
Build failed |
• Convert _AbstractStringStorage to a protocol, and the free functions used to deduplicate implementations to extensions on that protocol. • Move 'start' into the abstract type and use that to simplify some code • Move the ASCII fast path for length into UTF16View. • Add a weirder but faster way to check which (if any) of our NSString subclasses a given object is, and adopt it (cherry picked from commit 8b57921)
Add an isASCII fast-path for many UTF16View operations. These are heavily utilized in random-access scenarios, allowing us to both be more efficient and skip generating breadcrumbs for ASCII strings.
milseman
force-pushed
the
5_0_ascii_hotness
branch
from
e782a0b to
c9129d0
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
airspeedswift
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.0 cherry-pick of #20848