Skip to content

[benchmark] DictTest4Legacy: Add dummy hash(into:) #20867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2018

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Nov 29, 2018

(This PR was originally part of #20685.)

SE-0206 deprecated hashValue as a Hashable requirement, replacing it with hash(into:). This PR updates the benchmarking suite accordingly.

rdar://problem/46344811

The new definition is the same as the one synthesized by the compiler.
@lorentey
Copy link
Member Author

@swift-ci smoke test

@lorentey
Copy link
Member Author

@swift-ci benchmark

@swift-ci
Copy link
Contributor

Build comment file:

No performance and code size changes


@lorentey lorentey merged commit 30865dc into swiftlang:master Nov 29, 2018
@lorentey lorentey deleted the deprecate-hashValue-2 branch November 29, 2018 19:00
@lorentey lorentey restored the deprecate-hashValue-2 branch November 29, 2018 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants