[5.0] Cherry-pick important bug fix and ABI expunges #20844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_StringGutsSlice is an implementation helper that's no longer needed from inlinable code. Internalize it.
|
@swift-ci please test |
|
@apple/swift5-branch-managers @apple/swift5-branch-managers
This includes a bug fix that is needed for convergence if a user tries to call
This also removes a fair bit of ABI surface area that's not longer necessary. |
airspeedswift
approved these changes
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picks of:
#20812
#20768
#20651
These include bug fixes and dropping things from our ABI that didn't need to be there.