More small fixes #20626
Merged
More small fixes #20626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traction This also exposed a bug where we use a lowered type as an AST type and crash when emitting the '@unknown case' block. This block is unreachable when switching over non-enum values, but its emitted anyway. Fixes <https://bugs.swift.org/browse/SR-9159>, <rdar://problem/45962466>.
Fixes <rdar://problem/23427259>, <https://bugs.swift.org/browse/SR-4207>.
Fixes <rdar://problem/45962425>, <https://bugs.swift.org/browse/SR-9169>.
slavapestov
force-pushed
the
more-small-fixes
branch
from
d0dbd63 to
7ffe361
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
xedin
reviewed
Nov 16, 2018
| GenericSignatureBuilder *builder, | ||
| GenericParamList *genericParams, | ||
| GenericSignature *parentSig, | ||
| TypeResolution resolution) { | ||
| // If there is a parent context, add the generic parameters and requirements |
There was a problem hiding this comment.
Maybe it would be appropriate to assert that builder is not a nullptr here just to be on the safe side?
There was a problem hiding this comment.
I don’t think that’s necessary. We will hit a segfault immediately if it’s null.
This was referenced Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/45962466, rdar://problem/23427259, rdar://problem/45962425