[Runtime] Allow overrides or swift_getAssociated(Type|Conformance)Witness #20592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ness. Split these two functions into a fast path (for the cached case) and a slow path. Make the slow path overridable, so we can patch it in the future if needed.
|
@swift-ci please smoke test and merge |
mikeash
approved these changes
Nov 15, 2018
There was a problem hiding this comment.
Looks good! Can you add tests for these to unittests/runtime/CompatibilityOverride.cpp? Hopefully simple, the test doesn't need to actually pass sensible parameters, it just ensures that the override gets called when present.
This is probably not the right time for it, but I wonder if we can generate the tests themselves from the .def file too....
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
|
@mikeash added! |
|
@DougGregor <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split these two functions into a fast path (for the cached case) and a slow
path. Make the slow path overridable, so we can patch it in the future if
needed.