Skip to content

Some enable implicit dynamic fixes #20539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/Sema/TypeCheckAttr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2466,7 +2466,8 @@ void TypeChecker::addImplicitDynamicAttribute(Decl *D) {
isa<AccessorDecl>(D))
return;

if (!D->getAttrs().hasAttribute<DynamicAttr>()) {
if (!D->getAttrs().hasAttribute<DynamicAttr>() &&
!D->getAttrs().hasAttribute<DynamicReplacementAttr>()) {
auto attr = new (D->getASTContext()) DynamicAttr(/*implicit=*/true);
D->getAttrs().add(attr);
}
Expand Down
64 changes: 64 additions & 0 deletions test/Interpreter/Inputs/dynamic_replacement_module.swift
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,71 @@ public enum PublicEnumeration<Q> {
return "public_enum_generic_func"
}
}
#elseif MODULENODYNAMIC
public func public_global_func() -> String {
return "public_global_func"
}

public func public_global_generic_func<T>(_ t: T.Type) -> String {
return "public_global_generic_func"
}

public class PublicClass {
public var str : String = ""
public init() {}
public init(x: Int) { str = "public_class_init" }

public func function() -> String {
return "public_class_func"
}
public func genericFunction<T>(_ t: T.Type) -> String {
return "public_class_generic_func"
}
}

public struct PublicStruct {
public var str = ""
public init() {}

public init(x: Int) { str = "public_struct_init" }

public func function() -> String {
return "public_struct_func"
}
public func genericFunction<T>(_ t: T.Type) -> String {
return "public_struct_generic_func"
}
public var public_stored_property : String = "public_stored_property"

public subscript(_ x: Int) -> String {
get {
return "public_subscript_get"
}
set {
str = newValue
}
}
public subscript(y x: Int) -> String {
_read {
yield "public_subscript_get_modify_read"
}
_modify {
yield &str
}
}
}

public enum PublicEnumeration<Q> {
case A
case B

public func function() -> String {
return "public_enum_func"
}
public func genericFunction<T>(_ t: T.Type) -> String {
return "public_enum_generic_func"
}
}
#elseif MODULE2

import Module1
Expand Down
17 changes: 17 additions & 0 deletions test/Interpreter/dynamic_replacement.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,23 @@
// RUN: %target-codesign %t/main %t/libModule1.%target-dylib-extension %t/libModule2.%target-dylib-extension
// RUN: %target-run %t/main %t/libModule1.%target-dylib-extension %t/libModule2.%target-dylib-extension

// Test the -enable-implicit-dynamic flag.

// RUN: %empty-directory(%t)
// RUN: %target-build-swift-dylib(%t/libModule1.%target-dylib-extension) -DMODULENODYNAMIC -module-name Module1 -emit-module -emit-module-path %t/Module1.swiftmodule -swift-version 5 %S/Inputs/dynamic_replacement_module.swift -Xfrontend -enable-implicit-dynamic
// RUN: %target-build-swift-dylib(%t/libModule2.%target-dylib-extension) -I%t -L%t -lModule1 -Xlinker -rpath -Xlinker %t -DMODULE2 -module-name Module2 -emit-module -emit-module-path %t/Module2.swiftmodule -swift-version 5 %S/Inputs/dynamic_replacement_module.swift
// RUN: %target-build-swift -I%t -L%t -lModule1 -DMAIN -o %t/main -Xlinker -rpath -Xlinker %t %s -swift-version 5
// RUN: %target-codesign %t/main %t/libModule1.%target-dylib-extension %t/libModule2.%target-dylib-extension
// RUN: %target-run %t/main %t/libModule1.%target-dylib-extension %t/libModule2.%target-dylib-extension

// Test the -enable-implicit-dynamic flag in optimized wholemodule mode.
// RUN: %empty-directory(%t)
// RUN: %target-build-swift-dylib(%t/libModule1.%target-dylib-extension) -O -wmo -DMODULENODYNAMIC -module-name Module1 -emit-module -emit-module-path %t/Module1.swiftmodule -swift-version 5 %S/Inputs/dynamic_replacement_module.swift -Xfrontend -enable-implicit-dynamic
// RUN: %target-build-swift-dylib(%t/libModule2.%target-dylib-extension) -O -wmo -I%t -L%t -lModule1 -Xlinker -rpath -Xlinker %t -DMODULE2 -module-name Module2 -emit-module -emit-module-path %t/Module2.swiftmodule -swift-version 5 %S/Inputs/dynamic_replacement_module.swift
// RUN: %target-build-swift -O -wmo -I%t -L%t -lModule1 -DMAIN -o %t/main -Xlinker -rpath -Xlinker %t %s -swift-version 5
// RUN: %target-codesign %t/main %t/libModule1.%target-dylib-extension %t/libModule2.%target-dylib-extension
// RUN: %target-run %t/main %t/libModule1.%target-dylib-extension %t/libModule2.%target-dylib-extension


// REQUIRES: executable_test

Expand Down
5 changes: 5 additions & 0 deletions test/SILGen/dynamically_replaceable.swift
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
// RUN: %target-swift-emit-silgen -enable-sil-ownership -swift-version 5 %s | %FileCheck %s
// RUN: %target-swift-emit-silgen -enable-sil-ownership -swift-version 5 %s -enable-implicit-dynamic | %FileCheck %s --check-prefix=IMPLICIT

// CHECK-LABEL: sil hidden @$s23dynamically_replaceable014maybe_dynamic_B0yyF : $@convention(thin) () -> () {
// IMPLICIT-LABEL: sil hidden [dynamically_replacable] @$s23dynamically_replaceable014maybe_dynamic_B0yyF : $@convention(thin) () -> () {
func maybe_dynamic_replaceable() {
}

// CHECK-LABEL: sil hidden [dynamically_replacable] @$s23dynamically_replaceable08dynamic_B0yyF : $@convention(thin) () -> () {
dynamic func dynamic_replaceable() {
Expand Down