Skip to content

[stdlib] Remove _Unwrappable #20506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lorentey
Copy link
Member

There are no uses of the stdlib's _Unwrappable protocol, so there is no reason to keep it as ABI; we should remove it.

@lorentey
Copy link
Member Author

This was uncovered by @jrose-apple's improved diagnostics in #20485.

@lorentey lorentey requested a review from millenomi November 12, 2018 11:40
@lorentey
Copy link
Member Author

@swift-ci please smoke test

@jrose-apple
Copy link
Contributor

This was a necessary workaround at one point. What changed?

@lorentey
Copy link
Member Author

/home/buildnode/jenkins/workspace/swift-PR-Linux-smoke-test/branch-master/swift/stdlib/public/core/BridgeObjectiveC.swift:697:38: error: use of undeclared type '_Unwrappable'
00:25:32.196 if !done, let wrapper = source as? _Unwrappable {
00:25:32.196 ^~~~~~~~~~~~
00:25:32.196 ninja: build stopped: subcommand failed.

Ah, I see, grep failed me -- we still need it. We'll just want to rename unwrap to _unwrap, then.

@lorentey
Copy link
Member Author

Closing; I will submit a new PR to rename unwrap in a moment.

@lorentey lorentey closed this Nov 12, 2018
@lorentey
Copy link
Member Author

New PR is up; see #20511.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants