[ParseableInterface] Don't bother computing default witness tables #20437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
harlanhaskins
approved these changes
Nov 8, 2018
slavapestov
reviewed
Nov 8, 2018
| public func method() {} | ||
| } | ||
|
|
||
| // Make sure the default witness table is empty. |
There was a problem hiding this comment.
Can you change SILGen to not emit one at all?
There was a problem hiding this comment.
Sure, that's also a good idea.
|
Build failed |
These are only used within the original module today, so we can skip filling them in.
jrose-apple
force-pushed
the
default-in-our-stars
branch
from
f7d330b to
b17994c
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are only used within the original module today, so we can skip filling them in.