Skip to content

SourceKit: libdispatch swift requires swift stdlib #19639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2018

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Oct 1, 2018

When building libdispatch for SourceKit, only enable the swift overlay
components if the swift standard library is being built. This allows building
just the compiler and SourceKit.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

compnerd commented Oct 1, 2018

@swift-ci please test

@gottesmm
Copy link
Contributor

gottesmm commented Oct 1, 2018

@compnerd @akyrtzi Is this a useful build to verify? Maybe this needs a bot or something? Not sure.

@akyrtzi
Copy link
Contributor

akyrtzi commented Oct 1, 2018

@compnerd @akyrtzi Is this a useful build to verify? Maybe this needs a bot or something? Not sure.

SWIFT_BUILD_STDLIB is not specific to SourceKit. If a bot is necessary or not it should be considered in the context of building the Swift compiler project as a whole with SWIFT_BUILD_STDLIB set to NO, SourceKit is just another piece of it.

When building libdispatch for SourceKit, only enable the swift overlay
components if the swift standard library is being built.  This allows building
just the compiler and SourceKit.
@compnerd
Copy link
Member Author

compnerd commented Oct 1, 2018

@swift-ci please test and merge

@compnerd compnerd merged commit 373eec2 into swiftlang:master Oct 1, 2018
@compnerd compnerd deleted the nostdlib branch October 1, 2018 19:23
@swift-ci
Copy link
Contributor

swift-ci commented Oct 1, 2018

Build failed
Swift Test OS X Platform
Git Sha - 5657ee4c079e4adc1b27327ece2398461d136794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants