Skip to content

[benchmark] Alphabetic sorting of tests and warning about incorrect use of memory option #18211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2018
Merged

[benchmark] Alphabetic sorting of tests and warning about incorrect use of memory option #18211

merged 2 commits into from
Jul 25, 2018

Conversation

palimondo
Copy link
Contributor

This is a trivial follow-up to #18124 that ties a few loose ends:

  • Fix: alphabetic sorting of tests
  • Warn about incorrect --memory use

@palimondo
Copy link
Contributor Author

@eeckstein Please review 🙏

@palimondo palimondo force-pushed the fluctuation-of-the-pupil branch from dd9afa3 to 1a382ab Compare July 25, 2018 06:02
@palimondo palimondo changed the title [benchmark] [benchmark] Alphabetic sorting of tests and warning about incorrect use of memory option Jul 25, 2018
@eeckstein eeckstein self-requested a review July 25, 2018 17:47
eeckstein
eeckstein approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eeckstein
Copy link
Contributor

@swift-ci smoke test and merge

1 similar comment
@eeckstein
Copy link
Contributor

@swift-ci smoke test and merge

@eeckstein eeckstein merged commit b042215 into swiftlang:master Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palimondo @eeckstein