[build-presets] Foundation built based on platform #1764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the XCTest CI preset would attempt to build corelibs-foundation on OS X. corelibs-foundation is not meant to be built via the build-script on OS X, so this would cause issues. Remove the explicit `--foundation` option, and instead leave it up to the build-script to determine whether to build Foundation when building XCTest.
|
@shahmishal Unfortunately swiftlang/swift-corelibs-xctest#77 looks like it still failed on OS X. I think this change could get things working. |
|
@swift-ci Please test and merge |
|
Thanks, @shahmishal! Could you ask @swift-ci to please test swiftlang/swift-corelibs-xctest#77 again? 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Yet another attempt at getting the XCTest build preset to work on both Linux and OS X.
Previously, the XCTest CI preset would attempt to build corelibs-foundation on OS X. corelibs-foundation is not meant to be built via the build-script on OS X, so this would cause issues.
Remove the explicit
--foundationoption, and instead leave it up to the build-script to determine whether to build corelibs-foundation when building XCTest.Resolved bug number: None
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.