-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Remove _random() customization point #17604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please benchmark |
@swift-ci please test |
lorentey
approved these changes
Jun 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Hopefully we'll see some nice speedups.
Build failed |
Hm, the Linux failure seems unrelated. Let's try again, for luck? @swift-ci clean test linux platform |
Build comment file:Optimized (O)Regression (12)
Improvement (10)
No Changes (424)
Unoptimized (Onone)Regression (7)
Improvement (12)
No Changes (427)
Hardware Overview
|
stephentyrone
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #16863. @lorentey you said you weren't too worried about the
FixedWidthInteger._random()
implementation as it will soon use the new words initializer™, but I'm simply curious to see if this has any improvements for custom generators in any way. (Can you benchmark?)