[build-script] Link Objective-C runtime for XCTest #1748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XCTest CI is currently broken for OS X. Invoking `xcodebuild`, even when setting the correct `SWIFT_EXEC`, was unable to build Foundation. The problem was that a flag to link the Objective-C runtime was not being set as it would be when building with a Swift toolchain. Set the flag to get the builds passing. The XCTest CI presets should pass on all platforms with this change.
|
@shahmishal Is it possible to run CI with the XCTest preset with this change? |
|
@mike-ferris-apple Could you help ask @swift-ci to please test? Thanks! 🙏 |
@modocache This is not currently supported with swift-ci testing. |
|
@swift-ci Please smoke test |
|
Ah, too bad. Thanks anyway! In that case (assuming the tests pass), I'd like to merge this, then kick off a @swift-ci test on the swift-corelibs-xctest repository. I'm excited for that project to be tested on both Linux and OS X! |
|
@modocache Let me know once you merge this, I will trigger CI on swift-corelibs-xctest repository. |
modocache
added a commit
that referenced
this pull request
Mar 22, 2016
[build-script] Link Objective-C runtime for XCTest
|
Thanks, @shahmishal! How about kicking one off for swiftlang/swift-corelibs-xctest#77? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
The XCTest CI is currently broken for OS X. Invoking
xcodebuild, even when setting the correctSWIFT_EXEC, was unable to build Foundation. The problem was that a flag to link the Objective-C runtime was not being set as it would be when building with a Swift toolchain.Set the flag to get the builds passing. The XCTest CI presets should pass on all platforms with this change.
Resolved bug number: None
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.