Remove workaround for not being able to override generic method #1391
Conversation
|
@swift-ci Please test |
|
@Nirma The patch looks good. Let's see what the CI says. |
|
@gribozavr Sorry for that I pushed the fix, would you mind letting CI go again? |
|
@swift-ci Please test |
|
@Nirma OS X CI finished, could you take a look at the issues? |
|
@gribozavr Thanks for kicking off the tests again, the previous override error is gone but the failure this time appears to be: Is this related to this change? |
|
@Nirma No, swiftpm failure is unrelated (exists on master currently). |
|
@swift-ci Please test |
|
@Nirma Looks like there's a real OS X failure this time. |
|
@gribozavr The generic syntax was off, sorry about that. How does it look now? |
|
@swift-ci Please test |
| } | ||
| return result | ||
| } | ||
|
|
||
| /// If `Element` is bridged verbatim, invoke `body` on an | ||
| /// `UnsafeBufferPointer` to the elements. | ||
| internal final override func _withVerbatimBridgedUnsafeBufferImpl( |
There was a problem hiding this comment.
Does this function still override anything? Do we need to factor it as a separate function, or can we inline it into its only (as far as I can see) caller -- _withVerbatimBridgedUnsafeBuffer?
|
@gribozavr No it does not, so rather than just removing the override I can write it inline! |
…a generic subclass. Moved the implementation of the methods found in _ContiguousArrayStorage1 directly over to _ContiguousArrayStorage<Element>
|
@swift-ci Please test |
|
@Nirma Seems like we have test failures on OS X. |
|
There are non-trivial failures to resolve here and the PR hasn't been updated in 20 days; closing out the stale PR. |
Remove workaround for not being able to override a generic method in a generic subclass.
Moved the implementation of the methods found in
_ContiguousArrayStorage1directly over to_ContiguousArrayStorage<Element>and removed_ContiguousArrayStorage1.@gribozavr Thanks for pointing out this spot! How does it look?