Skip to content

[build-script] Overzealous path expansion #13319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2017
Merged

[build-script] Overzealous path expansion #13319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions utils/build_swift/driver_arguments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,8 @@ def create_argument_parser():
help='enable code coverage analysis in Swift (false, not-merged, '
'merged).')

option('--build-subdir', store_path,
option('--build-subdir', store,
metavar='PATH',
help='name of the directory under $SWIFT_BUILD_ROOT where the '
'build products will be placed')
option('--install-prefix', store_path,
Expand All @@ -315,7 +316,6 @@ def create_argument_parser():
option('--darwin-xcrun-toolchain', store,
default=defaults.DARWIN_XCRUN_TOOLCHAIN,
help='the name of the toolchain to use on Darwin')
# TODO: Add executable check to store_path
option('--cmake', store_path(executable=True),
help='the path to a CMake executable that will be used to build '
'Swift')
Expand Down