[build-script] Argument Builder DSL Conversion: Episode 2 #13164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please smoke test |
Rostepher
force-pushed
the
builder-dsl-episode-2
branch
from
dd8e19a to
46c4e43
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
Build failed |
|
Build failed |
…e the new builder DSL.
Rostepher
force-pushed
the
builder-dsl-episode-2
branch
from
46c4e43 to
6e27ff6
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
Build failed |
|
Build failed |
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
Build failed |
|
Build failed |
|
@swift-ci please test Linux |
|
@swift-ci please smoke test Linux |
AnthonyLatsis
added
build-script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is the second part of #13117 and similarly doesn't contain any real functional changes. I've only converted the rest of the argument groups (ignoring the top level options) to the new builder DSL. All the unit-tests still pass which makes me confident that this PR is low risk.
Ignore the first 8 commits, they are from #13117.
rdar://34336890