Reformat driver arguments #12954
Merged
Reformat driver arguments #12954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the first handful of commits, those are from #12873. Once that's merged I'll rebase this branch and they should disappear. |
Rostepher
force-pushed
the
reformat-driver-arguments
branch
4 times, most recently
from
0ba3411 to
d79919c
Compare
…g them with other argument groups.
…in order to remain consistent in style throughout the build_swift module.
… consistent and more readable.
…on strings first and then the action (if applicable).
Rostepher
force-pushed
the
reformat-driver-arguments
branch
from
d79919c to
3ac371e
Compare
|
@swift-ci please test |
|
@swift-ci please smoke test |
|
@swift-ci please test |
|
Build failed |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is a follow-up PR to #12873. There's no functional changes in this PR, rather just a bunch of reformatting in the
driver_arguments.pyfile to make all the argument parsing code more consistent.I've moved all the top-level arguments into a single grouping at the top of the parser code. Then I re-formatted all string literals to use single rather than double quotes. Lastly I re-ordered the arguments passed to
parser.add_argumentsuch thathelpis always last (for readability) andactioncomes first.rdar://34336890