Skip to content

[stdlib] Limit ranged subscript default implementations #12582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[stdlib] Limit ranged subscript default implementations #12582

wants to merge 1 commit into from

Conversation

natecook1000
Copy link
Member

This change limits the default implementations for subscript(Range) to collections where the SubSequence type matches the slice type that the implementation provides. This cuts down on the number of extraneous subscript overloads. (Related to #12029.)

@natecook1000
[stdlib] Limit ranged subscript default implementations
bdcb82d 
This change limits the default implementations for
subscript(Range<Index>) to collections where the SubSequence
type matches the slice type that the implementation provides. This
cuts down on the number of extraneous subscript overloads.
@natecook1000
Copy link
Member Author

@swift-ci Please smoke test macOS platform

@natecook1000
Copy link
Member Author

@swift-ci Please test source compatibility

@natecook1000 natecook1000 changed the title [WIP] [stdlib] Limit ranged subscript default implementations [stdlib] Limit ranged subscript default implementations Oct 24, 2017
@airspeedswift
Copy link
Member

@swift-ci please smoke test compiler performance

airspeedswift
airspeedswift approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@airspeedswift airspeedswift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm assuming it doesn’t hurt compile times (hopefully improves them...)

@natecook1000
Copy link
Member Author

@swift-ci Please smoke test Linux platform

@swift-ci
Copy link
Contributor

Build comment file:

Summary for master smoketest

Regressions found (see below)

Debug

PR vs. head (debug)

PR vs. head, changed counters (debug)

Regressed (30)
Regressed in Alamofire (7)
name old new delta delta_pct
Sema.NumConformancesDeserialized 34077 36420 2343 6.88% ⛔
Sema.NumGenericSignatureBuilders 3307 3327 20 0.6% ⛔
Sema.NumTypesDeserialized 155253 156102 849 0.55% ⛔
Sema.NumDeclsDeserialized 193046 193824 778 0.4% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 2495 2503 8 0.32% ⛔
Sema.NumLazyIterableDeclContexts 19120 19149 29 0.15% ⛔
Sema.NumLazyGenericEnvironments 30093 30122 29 0.1% ⛔
Regressed in Kingfisher (7)
name old new delta delta_pct
Sema.NumConformancesDeserialized 64942 71308 6366 9.8% ⛔
Sema.NumTypesDeserialized 297416 299342 1926 0.65% ⛔
Sema.NumGenericSignatureBuilders 9644 9696 52 0.54% ⛔
Sema.NumDeclsDeserialized 365964 367748 1784 0.49% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 5290 5316 26 0.49% ⛔
Sema.NumLazyIterableDeclContexts 49133 49187 54 0.11% ⛔
Sema.NumLazyGenericEnvironments 58932 58986 54 0.09% ⛔
Regressed in ReactiveCocoa (5)
name old new delta delta_pct
Sema.NumConformancesDeserialized 47294 50252 2958 6.25% ⛔
Sema.NumGenericSignatureBuilders 23528 23552 24 0.1% ⛔
Sema.NumTypesDeserialized 437152 437586 434 0.1% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 9212 9220 8 0.09% ⛔
Sema.NumDeclsDeserialized 505307 505393 86 0.02% ⛔
Regressed in ReactiveSwift (7)
name old new delta delta_pct
Sema.NumConformancesDeserialized 46804 50768 3964 8.47% ⛔
Sema.NumTypesDeserialized 224862 226066 1204 0.54% ⛔
Sema.NumDeclsDeserialized 268499 269619 1120 0.42% ⛔
Sema.NumGenericSignatureBuilders 8826 8856 30 0.34% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 5932 5946 14 0.24% ⛔
Sema.NumLazyIterableDeclContexts 28270 28306 36 0.13% ⛔
Sema.NumLazyGenericEnvironments 47286 47322 36 0.08% ⛔
Regressed in Result (4)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 2926 2928 2 0.07% ⛔
Sema.NumLazyGenericEnvironments 4864 4866 2 0.04% ⛔
Sema.NumTypesDeserialized 22334 22344 10 0.04% ⛔
Sema.NumDeclsDeserialized 26663 26667 4 0.02% ⛔
Improved (4)
Improved in Alamofire (1)
name old new delta delta_pct
Sema.NumConstraintScopes 39584 39510 -74 -0.19% ✅
Improved in ReactiveCocoa (3)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 98194 98174 -20 -0.02% ✅
Sema.NumLazyGenericEnvironments 96090 95814 -276 -0.29% ✅
Sema.NumConstraintScopes 62158 61950 -208 -0.33% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (81)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (15)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 5759 5759 0 0.0%
AST.NumLoadedModules 522 522 0 0.0%
AST.NumTotalClangImportedEntities 18308 18308 0 0.0%
AST.NumUsedConformances 432 432 0 0.0%
IRModule.NumIRBasicBlocks 13594 13594 0 0.0%
IRModule.NumIRFunctions 5110 5110 0 0.0%
IRModule.NumIRGlobals 4701 4701 0 0.0%
IRModule.NumIRInsts 132791 132791 0 0.0%
IRModule.NumIRValueSymbols 8430 8430 0 0.0%
LLVM.NumLLVMBytesOutput 3020476 3020476 0 0.0%
SILModule.NumSILGenFunctions 2458 2458 0 0.0%
SILModule.NumSILOptFunctions 4648 4648 0 0.0%
Sema.NumDeclsValidated 7149 7149 0 0.0%
Sema.NumFunctionsTypechecked 4054 4054 0 0.0%
Sema.NumTypesValidated 6298 6298 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (16)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 20266 20266 0 0.0%
AST.NumLoadedModules 1323 1323 0 0.0%
AST.NumTotalClangImportedEntities 57132 57132 0 0.0%
AST.NumUsedConformances 850 850 0 0.0%
IRModule.NumIRBasicBlocks 17779 17779 0 0.0%
IRModule.NumIRFunctions 7752 7752 0 0.0%
IRModule.NumIRGlobals 9063 9063 0 0.0%
IRModule.NumIRInsts 184365 184365 0 0.0%
IRModule.NumIRValueSymbols 14452 14452 0 0.0%
LLVM.NumLLVMBytesOutput 4945460 4945460 0 0.0%
SILModule.NumSILGenFunctions 4178 4178 0 0.0%
SILModule.NumSILOptFunctions 8447 8447 0 0.0%
Sema.NumDeclsValidated 9338 9338 0 0.0%
Sema.NumFunctionsTypechecked 12708 12708 0 0.0%
Sema.NumTypesValidated 14298 14298 0 0.0%
Sema.NumConstraintScopes 312304 312264 -40 -0.01%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (15)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 38866 38866 0 0.0%
AST.NumLoadedModules 3536 3536 0 0.0%
AST.NumTotalClangImportedEntities 110630 110630 0 0.0%
AST.NumUsedConformances 700 700 0 0.0%
IRModule.NumIRBasicBlocks 10868 10868 0 0.0%
IRModule.NumIRFunctions 6914 6914 0 0.0%
IRModule.NumIRGlobals 9656 9656 0 0.0%
IRModule.NumIRInsts 98701 98701 0 0.0%
IRModule.NumIRValueSymbols 14568 14568 0 0.0%
LLVM.NumLLVMBytesOutput 6509356 6509356 0 0.0%
SILModule.NumSILGenFunctions 2892 2892 0 0.0%
SILModule.NumSILOptFunctions 4369 4369 0 0.0%
Sema.NumDeclsValidated 4712 4712 0 0.0%
Sema.NumFunctionsTypechecked 23048 23048 0 0.0%
Sema.NumTypesValidated 34536 34536 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (16)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 3454 3454 0 0.0%
AST.NumLoadedModules 880 880 0 0.0%
AST.NumTotalClangImportedEntities 9062 9062 0 0.0%
AST.NumUsedConformances 724 724 0 0.0%
IRModule.NumIRBasicBlocks 19130 19130 0 0.0%
IRModule.NumIRFunctions 10541 10541 0 0.0%
IRModule.NumIRGlobals 12434 12434 0 0.0%
IRModule.NumIRInsts 314500 314500 0 0.0%
IRModule.NumIRValueSymbols 19287 19287 0 0.0%
LLVM.NumLLVMBytesOutput 8308136 8308136 0 0.0%
SILModule.NumSILGenFunctions 4813 4813 0 0.0%
SILModule.NumSILOptFunctions 7705 7705 0 0.0%
Sema.NumConstraintScopes 36536 36536 0 0.0%
Sema.NumDeclsValidated 20562 20562 0 0.0%
Sema.NumFunctionsTypechecked 3532 3532 0 0.0%
Sema.NumTypesValidated 70786 70786 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Result (19)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 338 338 0 0.0%
AST.NumLoadedModules 108 108 0 0.0%
AST.NumTotalClangImportedEntities 1098 1098 0 0.0%
AST.NumUsedConformances 62 62 0 0.0%
IRModule.NumIRBasicBlocks 1272 1272 0 0.0%
IRModule.NumIRFunctions 632 632 0 0.0%
IRModule.NumIRGlobals 758 758 0 0.0%
IRModule.NumIRInsts 16546 16546 0 0.0%
IRModule.NumIRValueSymbols 1172 1172 0 0.0%
LLVM.NumLLVMBytesOutput 399708 399708 0 0.0%
SILModule.NumSILGenFunctions 314 314 0 0.0%
SILModule.NumSILOptFunctions 642 642 0 0.0%
Sema.NumConformancesDeserialized 1994 1994 0 0.0%
Sema.NumConstraintScopes 3738 3738 0 0.0%
Sema.NumDeclsValidated 518 518 0 0.0%
Sema.NumFunctionsTypechecked 298 298 0 0.0%
Sema.NumGenericSignatureBuilders 468 468 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 486 486 0 0.0%
Sema.NumTypesValidated 1184 1184 0 0.0%

PR vs. head, changed timers (debug)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (9)
Unchanged (abs(delta) < 0.01% or 1000000usec) in Alamofire (1)
name old new delta delta_pct
time.swift-driver.Alamofire-all-x86_64_apple_macosx10.10-o-Onone.wall 5862023 5745792 -116231 -1.98%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Kingfisher (2)
name old new delta delta_pct
time.swift-driver.Kingfisher-all-arm64_apple_ios8.0-o-Onone.wall 4867961 4901622 33661 0.69%
time.swift-driver.Kingfisher-all-armv7_apple_ios8.0-o-Onone.wall 5059530 5056187 -3343 -0.07%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveCocoa (2)
name old new delta delta_pct
time.swift-driver.ReactiveCocoa-all-armv7_apple_ios8.0-o-Onone.wall 3625104 3651368 26264 0.72%
time.swift-driver.ReactiveCocoa-all-arm64_apple_ios8.0-o-Onone.wall 3606069 3604337 -1732 -0.05%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveSwift (2)
name old new delta delta_pct
time.swift-driver.ReactiveSwift-all-arm64_apple_ios8.0-o-Onone.wall 3588224 3601924 13700 0.38%
time.swift-driver.ReactiveSwift-all-armv7_apple_ios8.0-o-Onone.wall 3709951 3664492 -45459 -1.23%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Result (2)
name old new delta delta_pct
time.swift-driver.Result-all-arm64_apple_ios8.0-o-Onone.wall 1546954 1546992 38 0.0%
time.swift-driver.Result-all-armv7_apple_ios8.0-o-Onone.wall 1541101 1534987 -6114 -0.4%

PR vs. baseline (debug)

PR vs. baseline, changed counters (debug)

Regressed (21)
Regressed in Alamofire (5)
name old new delta delta_pct
SILModule.NumSILOptFunctions 3908 4648 740 18.94% ⛔
Sema.NumConformancesDeserialized 31066 36420 5354 17.23% ⛔
Sema.NumLazyGenericEnvironments 29740 30122 382 1.28% ⛔
LLVM.NumLLVMBytesOutput 2995540 3020476 24936 0.83% ⛔
Sema.NumDeclsDeserialized 193026 193824 798 0.41% ⛔
Regressed in Kingfisher (3)
name old new delta delta_pct
SILModule.NumSILOptFunctions 7512 8447 935 12.45% ⛔
LLVM.NumLLVMBytesOutput 4701704 4945460 243756 5.18% ⛔
Sema.NumConformancesDeserialized 70852 71308 456 0.64% ⛔
Regressed in ReactiveCocoa (9)
name old new delta delta_pct
Sema.NumConstraintScopes 42990 61950 18960 44.1% ⛔
LLVM.NumLLVMBytesOutput 4775608 6509356 1733748 36.3% ⛔
Sema.NumFunctionsTypechecked 18516 23048 4532 24.48% ⛔
AST.NumImportedExternalDefinitions 34112 38866 4754 13.94% ⛔
AST.NumTotalClangImportedEntities 101754 110630 8876 8.72% ⛔
SILModule.NumSILOptFunctions 4068 4369 301 7.4% ⛔
Sema.NumLazyGenericEnvironments 90692 95814 5122 5.65% ⛔
Sema.NumDeclsDeserialized 494670 505393 10723 2.17% ⛔
IRModule.NumIRGlobals 9536 9656 120 1.26% ⛔
Regressed in ReactiveSwift (4)
name old new delta delta_pct
SILModule.NumSILOptFunctions 6970 7705 735 10.55% ⛔
LLVM.NumLLVMBytesOutput 8049848 8308136 258288 3.21% ⛔
Sema.NumConformancesDeserialized 49822 50768 946 1.9% ⛔
IRModule.NumIRGlobals 12388 12434 46 0.37% ⛔
Improved (67)
Improved in Alamofire (17)
name old new delta delta_pct
SILModule.NumSILGenFunctions 2463 2458 -5 -0.2% ✅
AST.NumUsedConformances 435 432 -3 -0.69% ✅
IRModule.NumIRGlobals 4765 4701 -64 -1.34% ✅
Sema.NumTypesDeserialized 158862 156102 -2760 -1.74% ✅
IRModule.NumIRValueSymbols 8767 8430 -337 -3.84% ✅
IRModule.NumIRFunctions 5357 5110 -247 -4.61% ✅
Sema.NumLazyGenericEnvironmentsLoaded 2641 2503 -138 -5.23% ✅
IRModule.NumIRInsts 145724 132791 -12933 -8.87% ✅
Sema.NumConstraintScopes 43672 39510 -4162 -9.53% ✅
IRModule.NumIRBasicBlocks 15117 13594 -1523 -10.07% ✅
Sema.NumLazyIterableDeclContexts 21455 19149 -2306 -10.75% ✅
Sema.NumFunctionsTypechecked 5545 4054 -1491 -26.89% ✅
AST.NumImportedExternalDefinitions 8501 5759 -2742 -32.26% ✅
AST.NumTotalClangImportedEntities 27881 18308 -9573 -34.34% ✅
Sema.NumTypesValidated 18298 6298 -12000 -65.58% ✅
Sema.NumGenericSignatureBuilders 13996 3327 -10669 -76.23% ✅
Sema.NumDeclsValidated 61341 7149 -54192 -88.35% ✅
Improved in Kingfisher (19)
name old new delta delta_pct
SILModule.NumSILGenFunctions 4186 4178 -8 -0.19% ✅
IRModule.NumIRGlobals 9117 9063 -54 -0.59% ✅
AST.NumUsedConformances 858 850 -8 -0.93% ✅
Sema.NumLazyGenericEnvironmentsLoaded 5480 5316 -164 -2.99% ✅
IRModule.NumIRValueSymbols 14986 14452 -534 -3.56% ✅
IRModule.NumIRInsts 194978 184365 -10613 -5.44% ✅
IRModule.NumIRFunctions 8204 7752 -452 -5.51% ✅
IRModule.NumIRBasicBlocks 18956 17779 -1177 -6.21% ✅
Sema.NumDeclsDeserialized 406573 367748 -38825 -9.55% ✅
Sema.NumLazyIterableDeclContexts 54859 49187 -5672 -10.34% ✅
Sema.NumLazyGenericEnvironments 65900 58986 -6914 -10.49% ✅
Sema.NumTypesDeserialized 344515 299342 -45173 -13.11% ✅
AST.NumTotalClangImportedEntities 75188 57132 -18056 -24.01% ✅
Sema.NumFunctionsTypechecked 17534 12708 -4826 -27.52% ✅
AST.NumImportedExternalDefinitions 28988 20266 -8722 -30.09% ✅
Sema.NumConstraintScopes 581970 312264 -269706 -46.34% ✅
Sema.NumTypesValidated 27944 14298 -13646 -48.83% ✅
Sema.NumGenericSignatureBuilders 33750 9696 -24054 -71.27% ✅
Sema.NumDeclsValidated 125016 9338 -115678 -92.53% ✅
Improved in ReactiveCocoa (13)
name old new delta delta_pct
SILModule.NumSILGenFunctions 2904 2892 -12 -0.41% ✅
AST.NumUsedConformances 704 700 -4 -0.57% ✅
IRModule.NumIRValueSymbols 14686 14568 -118 -0.8% ✅
Sema.NumTypesDeserialized 447750 437586 -10164 -2.27% ✅
IRModule.NumIRFunctions 7080 6914 -166 -2.34% ✅
IRModule.NumIRInsts 102753 98701 -4052 -3.94% ✅
Sema.NumLazyIterableDeclContexts 105954 98174 -7780 -7.34% ✅
IRModule.NumIRBasicBlocks 11870 10868 -1002 -8.44% ✅
Sema.NumLazyGenericEnvironmentsLoaded 10174 9220 -954 -9.38% ✅
Sema.NumConformancesDeserialized 57916 50252 -7664 -13.23% ✅
Sema.NumTypesValidated 49050 34536 -14514 -29.59% ✅
Sema.NumGenericSignatureBuilders 49468 23552 -25916 -52.39% ✅
Sema.NumDeclsValidated 106644 4712 -101932 -95.58% ✅
Improved in ReactiveSwift (18)
name old new delta delta_pct
SILModule.NumSILGenFunctions 4833 4813 -20 -0.41% ✅
AST.NumUsedConformances 730 724 -6 -0.82% ✅
IRModule.NumIRValueSymbols 19619 19287 -332 -1.69% ✅
IRModule.NumIRFunctions 10863 10541 -322 -2.96% ✅
IRModule.NumIRInsts 332161 314500 -17661 -5.32% ✅
Sema.NumLazyGenericEnvironments 50740 47322 -3418 -6.74% ✅
Sema.NumDeclsDeserialized 291790 269619 -22171 -7.6% ✅
Sema.NumTypesDeserialized 253286 226066 -27220 -10.75% ✅
Sema.NumConstraintScopes 41650 36536 -5114 -12.28% ✅
IRModule.NumIRBasicBlocks 21814 19130 -2684 -12.3% ✅
Sema.NumFunctionsTypechecked 4538 3532 -1006 -22.17% ✅
Sema.NumLazyGenericEnvironmentsLoaded 7646 5946 -1700 -22.23% ✅
Sema.NumLazyIterableDeclContexts 37546 28306 -9240 -24.61% ✅
Sema.NumTypesValidated 100770 70786 -29984 -29.75% ✅
AST.NumImportedExternalDefinitions 6434 3454 -2980 -46.32% ✅
AST.NumTotalClangImportedEntities 24796 9062 -15734 -63.45% ✅
Sema.NumGenericSignatureBuilders 31134 8856 -22278 -71.56% ✅
Sema.NumDeclsValidated 75348 20562 -54786 -72.71% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (4)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (1)
name old new delta delta_pct
AST.NumLoadedModules 522 522 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (1)
name old new delta delta_pct
AST.NumLoadedModules 1323 1323 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (1)
name old new delta delta_pct
AST.NumLoadedModules 3536 3536 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (1)
name old new delta delta_pct
AST.NumLoadedModules 880 880 0 0.0%

PR vs. baseline, changed timers (debug)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (0)

Release

PR vs. head (release)

PR vs. head, changed counters (release)

Regressed (27)
Regressed in Alamofire (6)
name old new delta delta_pct
Sema.NumConformancesDeserialized 14472 14984 512 3.54% ⛔
Sema.NumGenericSignatureBuilders 416 420 4 0.96% ⛔
Sema.NumTypesDeserialized 22904 23082 178 0.78% ⛔
Sema.NumDeclsDeserialized 24138 24325 187 0.77% ⛔
Sema.NumLazyIterableDeclContexts 1660 1662 2 0.12% ⛔
Sema.NumLazyGenericEnvironments 2784 2786 2 0.07% ⛔
Regressed in Kingfisher (7)
name old new delta delta_pct
Sema.NumConformancesDeserialized 29184 31166 1982 6.79% ⛔
Sema.NumGenericSignatureBuilders 1101 1115 14 1.27% ⛔
Sema.NumTypesDeserialized 45237 45645 408 0.9% ⛔
Sema.NumDeclsDeserialized 48343 48735 392 0.81% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 826 832 6 0.73% ⛔
Sema.NumLazyIterableDeclContexts 3535 3539 4 0.11% ⛔
Sema.NumLazyGenericEnvironments 4992 4996 4 0.08% ⛔
Regressed in ReactiveCocoa (3)
name old new delta delta_pct
Sema.NumConformancesDeserialized 19444 20468 1024 5.27% ⛔
Sema.NumGenericSignatureBuilders 1280 1288 8 0.63% ⛔
Sema.NumLazyIterableDeclContexts 3784 3788 4 0.11% ⛔
Regressed in ReactiveSwift (7)
name old new delta delta_pct
Sema.NumConformancesDeserialized 24812 26794 1982 7.99% ⛔
Sema.NumTypesDeserialized 39552 39960 408 1.03% ⛔
Sema.NumGenericSignatureBuilders 1515 1529 14 0.92% ⛔
Sema.NumDeclsDeserialized 44010 44402 392 0.89% ⛔
Sema.NumLazyGenericEnvironmentsLoaded 828 834 6 0.72% ⛔
Sema.NumLazyIterableDeclContexts 2881 2885 4 0.14% ⛔
Sema.NumLazyGenericEnvironments 5184 5188 4 0.08% ⛔
Regressed in Result (4)
name old new delta delta_pct
Sema.NumLazyIterableDeclContexts 1976 1978 2 0.1% ⛔
Sema.NumLazyGenericEnvironments 4112 4114 2 0.05% ⛔
Sema.NumTypesDeserialized 20510 20520 10 0.05% ⛔
Sema.NumDeclsDeserialized 23858 23862 4 0.02% ⛔
Improved (5)
Improved in Alamofire (1)
name old new delta delta_pct
Sema.NumConstraintScopes 36446 36372 -74 -0.2% ✅
Improved in ReactiveCocoa (4)
name old new delta delta_pct
Sema.NumTypesDeserialized 38983 38835 -148 -0.38% ✅
Sema.NumConstraintScopes 37650 37442 -208 -0.55% ✅
Sema.NumDeclsDeserialized 41916 41488 -428 -1.02% ✅
Sema.NumLazyGenericEnvironments 6194 5902 -292 -4.71% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (83)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (16)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 881 881 0 0.0%
AST.NumLoadedModules 28 28 0 0.0%
AST.NumTotalClangImportedEntities 3234 3234 0 0.0%
AST.NumUsedConformances 432 432 0 0.0%
IRModule.NumIRBasicBlocks 15502 15502 0 0.0%
IRModule.NumIRFunctions 3579 3579 0 0.0%
IRModule.NumIRGlobals 4449 4449 0 0.0%
IRModule.NumIRInsts 113090 113090 0 0.0%
IRModule.NumIRValueSymbols 6898 6898 0 0.0%
LLVM.NumLLVMBytesOutput 3304536 3304536 0 0.0%
SILModule.NumSILGenFunctions 1860 1860 0 0.0%
SILModule.NumSILOptFunctions 3074 3074 0 0.0%
Sema.NumDeclsValidated 3290 3290 0 0.0%
Sema.NumFunctionsTypechecked 1104 1104 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 364 364 0 0.0%
Sema.NumTypesValidated 1592 1592 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (16)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 3406 3406 0 0.0%
AST.NumLoadedModules 61 61 0 0.0%
AST.NumTotalClangImportedEntities 9850 9850 0 0.0%
AST.NumUsedConformances 850 850 0 0.0%
IRModule.NumIRBasicBlocks 22501 22501 0 0.0%
IRModule.NumIRFunctions 5795 5795 0 0.0%
IRModule.NumIRGlobals 8574 8574 0 0.0%
IRModule.NumIRInsts 166293 166293 0 0.0%
IRModule.NumIRValueSymbols 12767 12767 0 0.0%
LLVM.NumLLVMBytesOutput 5865796 5865792 -4 -0.0%
SILModule.NumSILGenFunctions 3056 3056 0 0.0%
SILModule.NumSILOptFunctions 5842 5842 0 0.0%
Sema.NumDeclsValidated 4176 4176 0 0.0%
Sema.NumFunctionsTypechecked 2878 2878 0 0.0%
Sema.NumTypesValidated 2740 2740 0 0.0%
Sema.NumConstraintScopes 301126 301086 -40 -0.01%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (16)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 3138 3138 0 0.0%
AST.NumLoadedModules 66 66 0 0.0%
AST.NumTotalClangImportedEntities 7480 7480 0 0.0%
AST.NumUsedConformances 700 700 0 0.0%
IRModule.NumIRBasicBlocks 8787 8787 0 0.0%
IRModule.NumIRFunctions 4876 4876 0 0.0%
IRModule.NumIRGlobals 8491 8491 0 0.0%
IRModule.NumIRInsts 66215 66215 0 0.0%
IRModule.NumIRValueSymbols 12101 12101 0 0.0%
LLVM.NumLLVMBytesOutput 8779700 8779700 0 0.0%
SILModule.NumSILGenFunctions 1913 1913 0 0.0%
SILModule.NumSILOptFunctions 3147 3147 0 0.0%
Sema.NumDeclsValidated 2402 2402 0 0.0%
Sema.NumFunctionsTypechecked 2484 2484 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 702 702 0 0.0%
Sema.NumTypesValidated 2372 2372 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (16)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 512 512 0 0.0%
AST.NumLoadedModules 38 38 0 0.0%
AST.NumTotalClangImportedEntities 2102 2102 0 0.0%
AST.NumUsedConformances 730 730 0 0.0%
IRModule.NumIRBasicBlocks 21272 21272 0 0.0%
IRModule.NumIRFunctions 10078 10078 0 0.0%
IRModule.NumIRGlobals 11646 11646 0 0.0%
IRModule.NumIRInsts 256157 256157 0 0.0%
IRModule.NumIRValueSymbols 19422 19422 0 0.0%
LLVM.NumLLVMBytesOutput 9961852 9961852 0 0.0%
SILModule.NumSILGenFunctions 3735 3735 0 0.0%
SILModule.NumSILOptFunctions 6934 6934 0 0.0%
Sema.NumConstraintScopes 34930 34930 0 0.0%
Sema.NumDeclsValidated 7578 7578 0 0.0%
Sema.NumFunctionsTypechecked 1976 1976 0 0.0%
Sema.NumTypesValidated 23594 23594 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Result (19)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 316 316 0 0.0%
AST.NumLoadedModules 34 34 0 0.0%
AST.NumTotalClangImportedEntities 1300 1300 0 0.0%
AST.NumUsedConformances 62 62 0 0.0%
IRModule.NumIRBasicBlocks 2048 2048 0 0.0%
IRModule.NumIRFunctions 623 623 0 0.0%
IRModule.NumIRGlobals 687 687 0 0.0%
IRModule.NumIRInsts 20376 20376 0 0.0%
IRModule.NumIRValueSymbols 1194 1194 0 0.0%
LLVM.NumLLVMBytesOutput 482740 482740 0 0.0%
SILModule.NumSILGenFunctions 292 292 0 0.0%
SILModule.NumSILOptFunctions 813 813 0 0.0%
Sema.NumConformancesDeserialized 3922 3922 0 0.0%
Sema.NumConstraintScopes 3736 3736 0 0.0%
Sema.NumDeclsValidated 472 472 0 0.0%
Sema.NumFunctionsTypechecked 296 296 0 0.0%
Sema.NumGenericSignatureBuilders 368 368 0 0.0%
Sema.NumLazyGenericEnvironmentsLoaded 338 338 0 0.0%
Sema.NumTypesValidated 990 990 0 0.0%

PR vs. head, changed timers (release)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (9)
Unchanged (abs(delta) < 0.01% or 1000000usec) in Alamofire (1)
name old new delta delta_pct
time.swift-driver.Alamofire-all-x86_64_apple_macosx10.10-o-O.wall 11070910 11040390 -30520 -0.28%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Kingfisher (2)
name old new delta delta_pct
time.swift-driver.Kingfisher-all-armv7_apple_ios8.0-o-O.wall 11461340 11482130 20790 0.18%
time.swift-driver.Kingfisher-all-arm64_apple_ios8.0-o-O.wall 11264180 11274050 9870 0.09%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveCocoa (2)
name old new delta delta_pct
time.swift-driver.ReactiveCocoa-all-arm64_apple_ios8.0-o-O.wall 5197096 5220143 23047 0.44%
time.swift-driver.ReactiveCocoa-all-armv7_apple_ios8.0-o-O.wall 5165242 5183119 17877 0.35%
Unchanged (abs(delta) < 0.01% or 1000000usec) in ReactiveSwift (2)
name old new delta delta_pct
time.swift-driver.ReactiveSwift-all-armv7_apple_ios8.0-o-O.wall 11076530 11052210 -24320 -0.22%
time.swift-driver.ReactiveSwift-all-arm64_apple_ios8.0-o-O.wall 10885250 10833660 -51590 -0.47%
Unchanged (abs(delta) < 0.01% or 1000000usec) in Result (2)
name old new delta delta_pct
time.swift-driver.Result-all-armv7_apple_ios8.0-o-O.wall 2887435 2872659 -14776 -0.51%
time.swift-driver.Result-all-arm64_apple_ios8.0-o-O.wall 2844809 2828904 -15905 -0.56%

PR vs. baseline (release)

PR vs. baseline, changed counters (release)

Regressed (17)
Regressed in Alamofire (3)
name old new delta delta_pct
AST.NumTotalClangImportedEntities 2920 3234 314 10.75% ⛔
LLVM.NumLLVMBytesOutput 3172156 3304536 132380 4.17% ⛔
SILModule.NumSILOptFunctions 2991 3074 83 2.77% ⛔
Regressed in Kingfisher (6)
name old new delta delta_pct
AST.NumTotalClangImportedEntities 9086 9850 764 8.41% ⛔
LLVM.NumLLVMBytesOutput 5462712 5865792 403080 7.38% ⛔
SILModule.NumSILOptFunctions 5723 5842 119 2.08% ⛔
Sema.NumConformancesDeserialized 30795 31166 371 1.2% ⛔
AST.NumImportedExternalDefinitions 3368 3406 38 1.13% ⛔
Sema.NumFunctionsTypechecked 2848 2878 30 1.05% ⛔
Regressed in ReactiveCocoa (5)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 5480320 8779700 3299380 60.2% ⛔
Sema.NumConstraintScopes 23810 37442 13632 57.25% ⛔
SILModule.NumSILOptFunctions 2915 3147 232 7.96% ⛔
AST.NumTotalClangImportedEntities 7270 7480 210 2.89% ⛔
IRModule.NumIRGlobals 8486 8491 5 0.06% ⛔
Regressed in ReactiveSwift (3)
name old new delta delta_pct
LLVM.NumLLVMBytesOutput 9452416 9961852 509436 5.39% ⛔
SILModule.NumSILOptFunctions 6852 6934 82 1.2% ⛔
IRModule.NumIRGlobals 11628 11646 18 0.15% ⛔
Improved (66)
Improved in Alamofire (17)
name old new delta delta_pct
SILModule.NumSILGenFunctions 1861 1860 -1 -0.05% ✅
AST.NumUsedConformances 435 432 -3 -0.69% ✅
Sema.NumLazyGenericEnvironments 2814 2786 -28 -1.0% ✅
IRModule.NumIRGlobals 4521 4449 -72 -1.59% ✅
Sema.NumDeclsDeserialized 24875 24325 -550 -2.21% ✅
Sema.NumLazyIterableDeclContexts 1716 1662 -54 -3.15% ✅
Sema.NumTypesDeserialized 23832 23082 -750 -3.15% ✅
IRModule.NumIRValueSymbols 7218 6898 -320 -4.43% ✅
Sema.NumLazyGenericEnvironmentsLoaded 383 364 -19 -4.96% ✅
Sema.NumConstraintScopes 38683 36372 -2311 -5.97% ✅
IRModule.NumIRFunctions 3819 3579 -240 -6.28% ✅
IRModule.NumIRBasicBlocks 16869 15502 -1367 -8.1% ✅
IRModule.NumIRInsts 123248 113090 -10158 -8.24% ✅
Sema.NumConformancesDeserialized 16433 14984 -1449 -8.82% ✅
Sema.NumTypesValidated 1977 1592 -385 -19.47% ✅
Sema.NumGenericSignatureBuilders 1595 420 -1175 -73.67% ✅
Sema.NumDeclsValidated 17283 3290 -13993 -80.96% ✅
Improved in Kingfisher (15)
name old new delta delta_pct
Sema.NumDeclsDeserialized 48980 48735 -245 -0.5% ✅
IRModule.NumIRGlobals 8627 8574 -53 -0.61% ✅
AST.NumUsedConformances 858 850 -8 -0.93% ✅
Sema.NumTypesDeserialized 46208 45645 -563 -1.22% ✅
Sema.NumLazyIterableDeclContexts 3642 3539 -103 -2.83% ✅
Sema.NumLazyGenericEnvironments 5174 4996 -178 -3.44% ✅
IRModule.NumIRValueSymbols 13308 12767 -541 -4.07% ✅
Sema.NumLazyGenericEnvironmentsLoaded 876 832 -44 -5.02% ✅
IRModule.NumIRFunctions 6265 5795 -470 -7.5% ✅
IRModule.NumIRBasicBlocks 25356 22501 -2855 -11.26% ✅
IRModule.NumIRInsts 189828 166293 -23535 -12.4% ✅
Sema.NumTypesValidated 3794 2740 -1054 -27.78% ✅
Sema.NumConstraintScopes 564928 301086 -263842 -46.7% ✅
Sema.NumGenericSignatureBuilders 3925 1115 -2810 -71.59% ✅
Sema.NumDeclsValidated 35702 4176 -31526 -88.3% ✅
Improved in ReactiveCocoa (15)
name old new delta delta_pct
SILModule.NumSILGenFunctions 1917 1913 -4 -0.21% ✅
AST.NumUsedConformances 704 700 -4 -0.57% ✅
IRModule.NumIRValueSymbols 12322 12101 -221 -1.79% ✅
Sema.NumConformancesDeserialized 20926 20468 -458 -2.19% ✅
Sema.NumTypesDeserialized 39750 38835 -915 -2.3% ✅
Sema.NumLazyIterableDeclContexts 3880 3788 -92 -2.37% ✅
Sema.NumDeclsDeserialized 42739 41488 -1251 -2.93% ✅
Sema.NumLazyGenericEnvironmentsLoaded 728 702 -26 -3.57% ✅
IRModule.NumIRFunctions 5090 4876 -214 -4.2% ✅
Sema.NumLazyGenericEnvironments 6210 5902 -308 -4.96% ✅
IRModule.NumIRInsts 69895 66215 -3680 -5.27% ✅
IRModule.NumIRBasicBlocks 9437 8787 -650 -6.89% ✅
Sema.NumTypesValidated 4072 2372 -1700 -41.75% ✅
Sema.NumGenericSignatureBuilders 3612 1288 -2324 -64.34% ✅
Sema.NumDeclsValidated 20206 2402 -17804 -88.11% ✅
Improved in ReactiveSwift (19)
name old new delta delta_pct
Sema.NumLazyGenericEnvironments 5196 5188 -8 -0.15% ✅
Sema.NumConformancesDeserialized 26845 26794 -51 -0.19% ✅
AST.NumUsedConformances 732 730 -2 -0.27% ✅
SILModule.NumSILGenFunctions 3755 3735 -20 -0.53% ✅
Sema.NumFunctionsTypechecked 1990 1976 -14 -0.7% ✅
Sema.NumDeclsDeserialized 44930 44402 -528 -1.18% ✅
Sema.NumTypesDeserialized 40957 39960 -997 -2.43% ✅
IRModule.NumIRValueSymbols 19993 19422 -571 -2.86% ✅
Sema.NumLazyIterableDeclContexts 2982 2885 -97 -3.25% ✅
IRModule.NumIRFunctions 10605 10078 -527 -4.97% ✅
IRModule.NumIRInsts 271570 256157 -15413 -5.68% ✅
Sema.NumLazyGenericEnvironmentsLoaded 890 834 -56 -6.29% ✅
Sema.NumConstraintScopes 38598 34930 -3668 -9.5% ✅
Sema.NumTypesValidated 26352 23594 -2758 -10.47% ✅
IRModule.NumIRBasicBlocks 23918 21272 -2646 -11.06% ✅
AST.NumImportedExternalDefinitions 592 512 -80 -13.51% ✅
AST.NumTotalClangImportedEntities 2670 2102 -568 -21.27% ✅
Sema.NumGenericSignatureBuilders 4390 1529 -2861 -65.17% ✅
Sema.NumDeclsValidated 28656 7578 -21078 -73.56% ✅
Unchanged (abs(delta) < 0.01% or 100000usec) (9)
Unchanged (abs(delta) < 0.01% or 100000usec) in Alamofire (3)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 881 881 0 0.0%
AST.NumLoadedModules 28 28 0 0.0%
Sema.NumFunctionsTypechecked 1104 1104 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in Kingfisher (2)
name old new delta delta_pct
AST.NumLoadedModules 61 61 0 0.0%
SILModule.NumSILGenFunctions 3056 3056 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveCocoa (3)
name old new delta delta_pct
AST.NumImportedExternalDefinitions 3138 3138 0 0.0%
AST.NumLoadedModules 66 66 0 0.0%
Sema.NumFunctionsTypechecked 2484 2484 0 0.0%
Unchanged (abs(delta) < 0.01% or 100000usec) in ReactiveSwift (1)
name old new delta delta_pct
AST.NumLoadedModules 38 38 0 0.0%

PR vs. baseline, changed timers (release)

Regressed (0)
Improved (0)
Unchanged (abs(delta) < 0.01% or 1000000usec) (0)
Last baseline commit on smoketest-master-debug.csv 
commit 051207462e73c88493bbf2e49795efb88cb6c1ec
Author: Graydon Hoare 
Date:   Tue Oct 10 12:33:02 2017 -0700

    Update smoketest baselines for Swift version 4.0.1-dev (LLVM 2dedb62a0b, Clang ab7472e733, Swift 866e511daa)

Last baseline commit on smoketest-master-release.csv

commit 051207462e73c88493bbf2e49795efb88cb6c1ec
Author: Graydon Hoare 
Date:   Tue Oct 10 12:33:02 2017 -0700

    Update smoketest baselines for Swift version 4.0.1-dev (LLVM 2dedb62a0b, Clang ab7472e733, Swift 866e511daa)

@natecook1000
Copy link
Member Author

Closing as this is going to conflict with the conditional conformance improvements elsewhere.

@natecook1000 natecook1000 deleted the nc-subslice branch November 15, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airspeedswift airspeedswift airspeedswift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natecook1000 @airspeedswift @swift-ci