Skip to content

Revert erroneous renaming of test_*_host destinations to `test_*_de… #12127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

Rostepher
Copy link
Contributor

@Rostepher Rostepher commented Sep 26, 2017

Purpose

This PR reverts changes made in #11952 that renamed skip_test_*_host argument destinations to test_*_device. As it turns out host has a different meaning from device in this context that I was unaware of. I've corrected this mistake and renamed those destinations to test_*_host.

rdar://34641862
rdar://34597488

@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher added the bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. label Sep 26, 2017
@shahmishal
Copy link
Member

@swift-ci test

@Rostepher Rostepher merged commit a14524e into swiftlang:master Sep 26, 2017
@Rostepher Rostepher deleted the revert-host-device-change branch September 26, 2017 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants