New defaults module for build_swift argument parser
#11911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
Rostepher
changed the title
defaults module for build_swift argument parser
Merged
gottesmm
approved these changes
Sep 14, 2017
| DARWIN_DEPLOYMENT_VERSION_WATCHOS = '2.0' | ||
|
|
||
| UNIX_INSTALL_PREFIX = '/usr' | ||
| DARWIN_INSTALL_PREFIX = ('/Applications/Xcode.app/Contents/Developer/' |
There was a problem hiding this comment.
I noticed that some of the options here are not used below. Why are they here? Specifically UNIX_INSTALL_PREFIX or am I missing something?
There was a problem hiding this comment.
They will be used very soon. I just didn't want to add more complexity in #11827.
|
@swift-ci please smoke test |
…the argument parser to configure the default build behavior.
Rostepher
force-pushed
the
argparser-defaults-module
branch
from
3752897 to
f4ce818
Compare
|
@swift-ci please smoke test |
|
@swift-ci Please nominate Explanation: This is required staging for the larger task of refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is yet another small portion of code for staging #11827 and #11872. It adds a new
defaultsmodule tobuild_swiftthat will hold all default values of significant importance which ought be editable from a single source and easily viewable. There's no functional difference with this PR and should be good to just merge once the tests have passed.rdar://problem/34425097