Skip to content

[WIP] SR-237 Refactor build-script argument parsing logic into separate module #11827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[WIP] SR-237 Refactor build-script argument parsing logic into separate module #11827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ad4ae6f
Added defaults for a few hard-coded android values.
Rostepher Oct 25, 2017
eefec0c
Implemented a builder class for creating argument parsers using a dec…
Rostepher Oct 25, 2017
80485ad
Re-implemented the main driver argument parser using the new Argument…
Rostepher Oct 25, 2017
5fb944c
Updated the argument-parsing test suite to handle the new parser clas…
Rostepher Oct 25, 2017
3d6883d
Converted Clang and Swift compiler options to legacy copiler version …
Rostepher Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions utils/build-script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,8 @@ class BuildScriptInvocation(object):
diagnostics.fatal(
"can't find distcc-pump (please install distcc-pump)")

if args.host_target is None or args.stdlib_deployment_targets is None:
if args.host_target is None \
or len(args.stdlib_deployment_targets) == 0:
diagnostics.fatal("unknown operating system")

if args.symbols_package:
Expand Down Expand Up @@ -263,7 +264,7 @@ class BuildScriptInvocation(object):
args.build_ninja = True

# Set the default stdlib-deployment-targets, if none were provided.
if args.stdlib_deployment_targets is None:
if len(args.stdlib_deployment_targets) == 0:
stdlib_targets = \
StdlibDeploymentTarget.default_stdlib_deployment_targets()
args.stdlib_deployment_targets = [
Expand Down
Loading