[stdlib] Add OptionSet tests #11683
Merged
[stdlib] Add OptionSet tests #11683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
moiseev
suggested changes
Aug 29, 2017
| OptionSetTests.test("RawValue.SingleOption") { | ||
| let s = Days.friday | ||
|
|
||
| assert(s.rawValue == 32) |
There was a problem hiding this comment.
Here and everywhere why assert?
There was a problem hiding this comment.
expectEqual or expectTrue.
| let member1 = s.update(with: .monday) | ||
|
|
||
| assert(s.contains(.monday)) | ||
| expectEqual(member1, nil) |
| expectEqual(member1, nil) | ||
|
|
||
| let member2 = s.update(with: .monday) | ||
| expectEqual(member2, .monday) |
|
I have a separate bug for the SetAlgebra tests |
added 2 commits
August 29, 2017 16:11
|
@swift-ci please smoke test |
moiseev
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test our public OptionSet API
This adds validation tests for the public API of OptionSet.