-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Add cases .ObjCRuntime and .NativeRuntime to StdlibUnittest's TestPredicate #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1232,6 +1234,9 @@ public enum TestRunPredicate : CustomStringConvertible { | |||
|
|||
case FreeBSDAny(reason: let reason): | |||
return "FreeBSDAny(*, reason: \(reason))" | |||
|
|||
case noObjC(let reason): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would phrase it avoiding the negation: case ObjCRuntime
, case NativeRuntime
. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that. Are you thinking two different cases, then?
Replaced the @gribozavr While we're at it, I was wondering whether cases |
2f67c89
to
6879dbd
Compare
I'd personally rather name these "Apple" and "NonApple", rather than using the presence of the runtime as a stand-in. (And if we start testing swift-corelibs-foundation on OS X as "non-objc-runtime", we'll need that distinction!) |
Seems to me that referring to the runtime is more precise; and your swift-corelibs-foundation aside appears to undermine the "Apple" and "NonApple" nomenclature. Surely I am misunderstanding? |
Let's deal with swift-corelibs-foundation distinction later. I'm not sure it will even come up, because this repository can't depend on corelibs-foundation -- that would be circular. For now, for compile-time requirements and for lit I agree about |
@swift-ci Please test |
Add cases .ObjCRuntime and .NativeRuntime to StdlibUnittest's TestPredicate
This predicate case evaluates to
false
#if_runtime(_ObjC)
,true
otherwise.