[validation-test][FreeBSD] xfail Foundation check #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "sorted/strings" test compares string sorting between Foundation and ICU. Foundation is only available on OS X, so the test is expected to fail on Linux. Foundation isn't available on FreeBSD either, so disable it for that platform as well.
|
LGTM but it needs review/approval from somebody in the swift team. |
gribozavr
added a commit
that referenced
this pull request
Jan 27, 2016
…-any [validation-test][FreeBSD] xfail Foundation check
|
Thanks! |
MaxDesiatov
pushed a commit
to MaxDesiatov/swift
that referenced
this pull request
Jun 5, 2020
[pull] swiftwasm from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "sorted/strings" test compares string sorting between Foundation and ICU. Foundation is only available on OS X, so the test is expected to fail on Linux. Foundation isn't available on FreeBSD either, so disable it for that platform as well.
This should fix one of the failing tests for FreeBSD. /cc @dcci, in case you'd like to confirm 😃