whitespace and typo #104
Merged
whitespace and typo #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I belive these are test comments for the parser. Changes in this file should be reverted.
Contributor
|
You're right, thanks. This broke a regression test too. I reverted that change in 6026b6d. -Chris |
Contributor
|
Understood, are those changes causing a problem? |
|
Not that I've found. Just pointing them out in case they were test cases that now don't exist. |
DougGregor
added a commit
to DougGregor/swift
that referenced
this pull request
Sep 11, 2017
Addressed ABI FIXME’s swiftlang#104 and swiftlang#105, making Sequence’s SubSequence conform to Sequence, with the same element type, and for which the SubSequence of a SubSequence is the same SubSequence.
DougGregor
added a commit
to DougGregor/swift
that referenced
this pull request
Sep 12, 2017
Addressed ABI FIXME’s #4, swiftlang#5, swiftlang#104 and swiftlang#105, making Sequence’s SubSequence conform to Sequence, with the same element type, and for which the SubSequence of a SubSequence is the same SubSequence. Fixes SR-318 / rdar://problem/31418206.
DougGregor
added a commit
to DougGregor/swift
that referenced
this pull request
Oct 1, 2017
Addressed ABI FIXME’s #4, swiftlang#5, swiftlang#104 and swiftlang#105, making Sequence’s SubSequence conform to Sequence, with the same element type, and for which the SubSequence of a SubSequence is the same SubSequence. Fixes SR-318 / rdar://problem/31418206.
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Sep 19, 2018
Fix `newline` token length calculation
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
build-script: remove any swift files in the generated file dir before generating new ones
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
XFAIL JSQDataSourcesKit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.