Skip to content

get_architecture_value and ndk_platform_triple is no longer used in test/lit.cfg and can be removed #63907

@WeZZard

Description

@WeZZard

Description
I configured pylance for lit config scripts in the test directory and find that in current main branch, at the line 1572 of the file test/lit.cfg there is:

            result = kwards["aarch64"]

which should be:

            result = kwargs["aarch64"]

which make the variable ndk_platform_triple below receives incorrect value.

The variable ndk_platform_triple is introduced in the pull request [android] Modify test scripts for aarch64 and modern NDKs. but the use sites of the variable ndk_platform_triple are removed in the pull request [android] Modify test scripts for aarch64 and modern NDKs. and [android] Update to NDK 23b. Thus the get_architecture_value function and ndk_platform_triple could be removed now.

Environment
swift main branch, test/lit.cfg

Metadata

Metadata

Assignees

No one assigned

    Labels

    AndroidPlatform: AndroidbugA deviation from expected or documented behavior. Also: expected but undesirable behavior.cross-compilationArea → utils: Cross-compilation of project sourcestest suiteArea: test suite

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions