TSCBasic: make FS-related value types Sendable #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
changed the title
MaxDesiatov
commented
Jan 18, 2023
| @@ -122,17 +122,17 @@ public enum FileMode { | |||
| case userWritable | |||
| case executable | |||
|
|
|||
| internal var setMode: (Int16) -> Int16 { | |||
| public func setMode(_ originalMode: Int16) -> Int16 { | |||
There was a problem hiding this comment.
I wanted to pull in some of the FS-related code into SwiftPM, but that depends on this function being public. That was also a good opportunity to convert it from this unconventional var-returning-a-closure notation.
|
@swift-ci test |
MaxDesiatov
requested review from
aciidgh,
abertelrud,
neonichu,
friedbunny and
tomerd
as code owners
|
@swift-ci test |
|
@swift-ci test |
MaxDesiatov
changed the title
|
@swift-ci test macOS |
MaxDesiatov
changed the title
tomerd
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
FileSystem-related code inasynccontext we need these types to beSendable.