Windows: replace MSVCRT with CRT
#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the migration path to remove the use of the `visualc` module from the Swift SDK for Windows. The use of the `stdout` and `stderr` types requires the use of the Swift overlay as the C library interfaces are not directly usable with the same name.
compnerd
requested review from
abertelrud,
aciidgh,
friedbunny and
neonichu
as code owners
|
@swift-ci please test |
|
Please do not merge this - this needs to be synchronized with swiftlang/swift#34299 |
|
Sounds good. Should we mark as Draft to prevent it from getting merged? |
|
@abertelrud - once it is accepted, I think that I should be able to coordinate the changes in short order (I have all the changes ready to go except this one, and once this is done, I'll coordinate with Nate to get them all merged simultaneously) |
|
@compnerd That sounds good — I misunderstood, and was just going off of the note to please not merge yet (which I've seen done in other cases by marking as Draft until it can be merged). As far as I'm concerned this can be merged any time. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the migration path to remove the use of the
visualcmodule from the Swift SDK for Windows. The use of the
stdoutandstderrtypes requires the use of the Swift overlay as the C libraryinterfaces are not directly usable with the same name.