CMake: Use CMAKE_SYSTEM_NAME STREQUAL "WASI" instead of WASI
#700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `WASI` variable is only available in the bleeding-edge CMake and not released versions yet (https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9659). So, we should use the old way for now.
kateinoigakukun
requested review from
stmontgomery,
grynspan,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
stmontgomery
approved these changes
Sep 17, 2024
|
@swift-ci please test |
grynspan
approved these changes
Sep 17, 2024
grynspan
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
WASIvariable is only available in the bleeding-edge CMake and not released versions yet(https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9659). So, we should use the old way for now.
I forgot to check CMake build in #699 🤦