Make Comment.Kind conform to Codable
#69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisweissmann
requested review from
SeanROlszewski,
briancroom,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
grynspan
approved these changes
Oct 17, 2023
This was referenced Oct 22, 2023
stmontgomery
added
the
tools integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to explicitly mark
Comment.KindasCodablein #68.Motivation:
An explicit conformance makes it clearer that
Comment.Kindconforms toCodable.Modifications:
Added an explicit conformance of
CodabletoComment.Kind.Result:
Comment.Kindnow explicitly conforms toCodable.