Explicitly add visionOS availability to tests that check availability. #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briancroom
requested review from
SeanROlszewski,
dennisweissmann,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
dennisweissmann
approved these changes
May 21, 2024
Contributor
Author
|
@swift-ci please test |
Contributor
|
Merging on Brian's behalf. |
grynspan
added a commit
that referenced
this pull request
May 21, 2024
…lability. (#424)" (#426) This reverts commit 406564e. The revert is needed because Swift 5.10 does not recognize visionOS and swift-testing does not currently have the ability to conditionalize availability with `#if compiler(>=5.11)`. We can reapply the change in the future if/when we require Swift 6. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since swiftlang/swift#72834, the Swift compiler supports visionOS availability annotations. For completeness, add this platform to existing tests which declare Apple platform availability.