Enable pthread_mutex_t use on WASI with a multithreaded runtime.
#322
+8
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR opts WASI builds into using `pthread_mutex_t` in `Locked` when the WASI environment supports threading. `_runtime(_multithreaded)` was added very recently with swiftlang/swift#72649, so we need an additional compiler version check before testing the runtime flag. WASI with Swift 5.10, as well as WASI without threading, will continue to stub out `Locked`.
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
grynspan
requested review from
kateinoigakukun
and removed request for
stmontgomery,
briancroom,
SeanROlszewski,
dennisweissmann and
suzannaratcliff
|
@kateinoigakukun, does this look right to you? |
|
@swift-ci please test |
…o assume it will be available in Swift 6.1 instead.
grynspan
requested review from
stmontgomery,
briancroom,
SeanROlszewski,
dennisweissmann and
suzannaratcliff
|
@swift-ci please test |
kateinoigakukun
approved these changes
Mar 31, 2024
briancroom
approved these changes
Apr 1, 2024
dennisweissmann
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR opts WASI builds into using
pthread_mutex_tinLockedwhen the WASI environment supports threading._runtime(_multithreaded)was added very recently with swiftlang/swift#72649, so we need an additional compiler version check before testing the runtime flag. That change has not been cherry-picked to Swift 6.0, so assume 6.1 or later is needed.WASI with Swift 5.10, as well as WASI without threading, will continue to stub out
Locked.Checklist: