Support: fix Environment.variable(named:) on Windows
#114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
ejvaughan,
grynspan,
stmontgomery and
suzannaratcliff
as code owners
briancroom
approved these changes
Nov 13, 2023
grynspan
reviewed
Nov 13, 2023
The return value being `0` may or may not indicate. We need to additionally check `GetLastError` to see if `ERROR_ENVVAR_NOT_FOUND` is set to indicate the missing variable. Otherwise, the variable is just an empty string. This repairs the 2 failing tests on Windows. Thanks to @grynspan for the fix!
grynspan
approved these changes
Nov 13, 2023
Contributor
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value being
0may or may not indicate. We need to additionally checkGetLastErrorto see ifERROR_ENVVAR_NOT_FOUNDis set to indicate the missing variable. Otherwise, the variable is just an empty string. This repairs the 2 failing tests on Windows.Thanks to @grynspan for the fix!