[CodeGeneration] Improve identifier backticking #2813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Aug 22, 2024
CodeGeneration/Sources/SyntaxSupport/IdentifierConvertible.swift
Outdated
Show resolved
Hide resolved
AppAppWorks
force-pushed
the
improve-identifier-backticking
branch
from
a159168 to
ac8577f
Compare
ahoppen
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Looking great.
I’m waiting for swiftlang/swift#76040 to be merged, which is currently blocking CI, before running CI on this PR.
|
Apparently the fixes have been merged :) |
|
@swift-ci Please test |
|
Thanks for the ping, I forgot about this PR. |
|
Looks like the tests in the |
- tackled redundant, inconsistent, and omitted backticking of identifiers
auto-merge was automatically disabled
August 27, 2024 00:03
Head branch was pushed to by a user without write access
AppAppWorks
force-pushed
the
improve-identifier-backticking
branch
from
ac8577f to
d0558dc
Compare
|
My bad, I wasn't aware CodeGeneration has its own test set... |
|
Haha, yeah, it’s not that obvious. |
|
This PR is now prime for another round of ci-test after the latest commit :) |
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there're a lot of redundant, inconsistent, or potentially omitted instances of identifier backticking in code generation, this PR aims to fix the issue.