[6.0][Windows] Avoid linking with swiftWinSDK.dll #2686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid 'import WinSDK' in swift sources or `#include` in headers. This is to avoid linking with Swift overlay library (swiftWinSDK.dll) so swift-frontend with plugins won't depends on it. (cherry picked from commit d360086)
|
@swift-ci Please test |
compnerd
approved these changes
Jun 17, 2024
bnbarham
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2685 into
release/6.0import WinSDKin swift sources or#include <windows.h>in headers. This is to avoid linking with Swift overlay library (swiftWinSDK.dll) soswift-frontendwith plugins won't depends on it._SwiftLibraryPluginProviderCShimsto the build system, it's just a static library so the final product should be equivalent, as long as the build succeeds