[Macros] Implement expansion of conformance macros #1773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow, we forgot to implement this here, even though the compiler has supported it for a long time. Fixes swiftlang#1742 / rdar://110418242.
|
@swift-ci please test |
ahoppen
reviewed
Jun 13, 2023
| extension \(raw: identifier): \(type) { } | ||
| """ | ||
| if let whereClause { | ||
| ext = DeclSyntax((ext.as(ExtensionDeclSyntax.self))!.with(\.genericWhereClause, whereClause)) |
There was a problem hiding this comment.
Slightly nicer version in my opinion would be
Suggested change
| ext = DeclSyntax((ext.as(ExtensionDeclSyntax.self))!.with(\.genericWhereClause, whereClause)) | |
| ext = DeclSyntax((ext.cast(ExtensionDeclSyntax.self)).with(\.genericWhereClause, whereClause)) |
There was a problem hiding this comment.
Thank you, I've pulled this in!
| // refer to conformance macros, expand them and return the resulting | ||
| // set of extension declarations. | ||
| private func expandConformances(of decl: DeclGroupSyntax) -> [DeclSyntax] { | ||
| let identifier: String |
There was a problem hiding this comment.
Why not make identifier: Syntax and then you don’t need to convert to strings or use the raw interpolation below. Also identifier isn’t correct because ext.extendedType is not an identifier.
There was a problem hiding this comment.
Great point, I've updated this code.
|
@swift-ci please test |
|
@swift-ci please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow, we forgot to implement this here, even though the compiler has supported it for a long time.
Fixes #1742 / rdar://110418242.