BasicFormat should not format unexpected nodes #1759
Conversation
|
@swift-ci please test |
CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/SyntaxRewriterFile.swift
Show resolved
Hide resolved
bnbarham
force-pushed
the
macro-formatting
branch
from
d9a1976 to
1e75014
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
macro-formatting
branch
from
1e75014 to
28f0fd8
Compare
|
@swift-ci please test |
bnbarham
force-pushed
the
macro-formatting
branch
from
28f0fd8 to
1e76baf
Compare
|
@swift-ci please test |
| @@ -475,6 +475,7 @@ extension OperatorTable { | |||
| ) { | |||
| self.opPrecedence = opPrecedence | |||
| self.errorHandler = errorHandler | |||
| super.init(viewMode: .sourceAccurate) | |||
There was a problem hiding this comment.
Do we really only want to fold source accurate nodes here? I would think of sequence folding as a semantic operation and thus think that it might be better off folding the fixed up tree.
There was a problem hiding this comment.
Ideally we wouldn't be folding at all if there's any errors 😅. Let's say there's a bunch of unexpected nodes, do we expect folding to remove them all?
There was a problem hiding this comment.
Ah, except we won't remove them (thanks @rintaro). So I suppose I don't really have a preference here. I can do fixed up 🤷
|
swift-format also uses |
bnbarham
force-pushed
the
macro-formatting
branch
3 times, most recently
from
bae6ff8 to
2c46280
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
bnbarham
force-pushed
the
macro-formatting
branch
from
2c46280 to
96cc428
Compare
`BasicFormat` depends on the parent layout nodes to determine formatting in some cases, so it doesn't make sense to visit unexpected nodes. Also fix up `SyntaxRewriter` to take a `viewMode`, since as it was `BasicFormat` was actually visiting `missing` nodes, which also doesn't make much sense. Resolves rdar://110463876.
bnbarham
force-pushed
the
macro-formatting
branch
from
96cc428 to
9227d5b
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
BasicFormatdepends on the parent layout nodes to determine formatting in some cases, so it doesn't make sense to visit unexpected nodes.Also fix up
SyntaxRewriterto take aviewMode, since as it wasBasicFormatwas actually visitingmissingnodes, which also doesn't make much sense.Resolves rdar://110463876.