[CMake] Updates to allow inclusion using FetchContent #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etcwilde
reviewed
May 20, 2023
|
Updated to remove export if not a top level project + add to SWIFT_EXPORTS otherwise. |
bnbarham
force-pushed
the
fetch-content
branch
from
8838189 to
73aad0a
Compare
DougGregor
approved these changes
Aug 17, 2023
Various updates that allow swift-syntax to be included using FetchContent. Mostly this is just not replacing `target_link_libraries` since that is a global replacement, but we also now use a couple of variables from the swift if they're set (eg. `SWIFT_HOST_LIBRARIES_DEST_DIR` and `SWIFT_HOST_MODULE_TRIPLE`).
bnbarham
force-pushed
the
fetch-content
branch
from
73aad0a to
47ca712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates that allow swift-syntax to be included using FetchContent.
Mostly this is just not replacing
target_link_librariessince that is a global replacement, but we also now use a couple of variables from the swift if they're set (eg.SWIFT_HOST_LIBRARIES_DEST_DIRandSWIFT_HOST_MODULE_TRIPLE).